Under FireFox only the first encountered button is decorated

7 posts, 0 answers
  1. CSurieux
    CSurieux avatar
    465 posts
    Member since:
    Jan 2007

    Posted 19 Nov 2009 Link to this post

    Hello,

    RadformDecorator with default option and v Q309 (3.111).
    Under FF3, It appears that only the first button from several (3) buttons is decorated, for IE everything is Ok.
    I changed the order and the first is the only decorated.

    Here is the code for buttons:

                <input onclick="FullScreen()" type="button" value="MEDIA_WARNING_FULLSCREEN" id="btnFullScreen" runat="server" /> 
                <input onclick="PauseMe()" type="button" value="MEDIA_PAUSE" id="btnPause" runat="server" />   
                <input onclick="StopMe()" type="button" value="MEDIA_STOP" id="btnStop" runat="server" /> 
     

    Is it a bug ?

    CS
  3. Martin
    Admin
    Martin avatar
    585 posts

    Posted 20 Nov 2009 Link to this post

    Hello Christian Surieux,

    Thanks for the provided markup, however I was not able to reproduce the issue you have encountered, and you are the first of our customers to report such behavior. As you can see from the screenshot I've attached to this message, your buttons are skinned, so I will appreciate if you send me a sample project where the issue is clearly visible. Also - make sure that the buttons that do not get skinned do not have a class name, because FormDecorator skips controls with a defined CSS class. And finally - make sure that the unskinned buttons are not outside of a decoration zone.

    Sincerely yours,
    Martin Ivanov
    the Telerik team

    Instantly find answers to your questions on the new Telerik Support Portal.
    Watch a video on how to optimize your support resource searches and check out more tips on the blogs.
  5. CSurieux
    CSurieux avatar
    465 posts
    Member since:
    Jan 2007

    Posted 20 Nov 2009 Link to this post

    Hello Martin,

    Thanks you for fast answer.
    Here you could see the pb using FF:
    http://www.addonnice.com/site/alias__addonnice/1057/Videos_Demo.aspx

    I am using the Hay skin in this theme.

    Waiting for your feedback.

    Regards
    CS
  7. Martin
    Admin
    Martin avatar
    585 posts

    Posted 20 Nov 2009 Link to this post

    Hello Christian Surieux,

    Thanks for the URL. I think I've figured it out:

    I noticed that you are disabling the Pause and Stop buttons on the client with JavaScript (when a button is found disabled on the page, FormDecorator appends to it a special .rgdDisabled class, and on the other hand FormDecorator does not decorate elements with a CSS class name applied, and the problem is due to the different support for onpropertychange in different browser)s, and it seems that the issue with FF has something to do with the execution of that script.

    I suggest that you disable the buttons with a little timeout, in order to ensure that FormDecorator has already done its job on the page. Or another approach - set the buttons disabled from the server, and enable them on the client when the Play button is pressed (or accoring to the logic of the player).

    Sincerely yours,
    Martin Ivanov
    the Telerik team

    Instantly find answers to your questions on the new Telerik Support Portal.
    Watch a video on how to optimize your support resource searches and check out more tips on the blogs.
  9. CSurieux
    CSurieux avatar
    465 posts
    Member since:
    Jan 2007

    Posted 20 Nov 2009 Link to this post

    Martin,

    I understand but if I wait some time before disabling (what I already did because I added my Init script to RadAjaxManager.Response.script which set a timeout before executing ->I will check this again) the button will get decorated as 'normal' but when their status will change to 'disabled' they will stay with the normal appearence if propertychange is not catched, no ? Same pb disabling from server ?


    CS
  11. Martin
    Admin
    Martin avatar
    585 posts

    Posted 20 Nov 2009 Link to this post

    Hello Christian Surieux,

    Yes, onpropertychange is hard to support with different browsers, but actually listening to enable / disable chanhes on buttons on the client under IE and FF is already working properly with FormDecorator - I just checked this out. Unfortunately, the case with WebKit browser is still unsolverd, but you may fix it with a script like this:

    function enablebtn(btnid)
    {
     var isWebKit = navigator.userAgent.toLowerCase().indexOf('webkit') > -1;
     var btn = document.getElementById(btnid);
     var parent = btn.parentNode;
     btn.disabled = false;
     
     if(isWebKit)
     {
      parent.className = 'rfdSkinnedButton';
     }
    }

    ... Here is a test markup for the script:

    <a href="javascript:void(0)" onclick="enablebtn('Btn1');">enable button</a>

    <input type="button" value="aaaa" id="Btn1" disabled="disabled" onclick="alert('Button Clicked!')" />

    Sincerely yours,
    Martin Ivanov
    the Telerik team

    Instantly find answers to your questions on the new Telerik Support Portal.
    Watch a video on how to optimize your support resource searches and check out more tips on the blogs.
  13. CSurieux
    CSurieux avatar
    465 posts
    Member since:
    Jan 2007

    Posted 20 Nov 2009 Link to this post

    Perfect, thank you.
    CS
Back to Top