This is a migrated thread and some comments may be shown as answers.

EditForm problem - other rows display incorrectly when editing/inserting a record

2 Answers 13 Views
This is a migrated thread and some comments may be shown as answers.
Top achievements
Rank 1
David asked on 28 Jul 2014, 05:34 PM
I am trying to create a custom EditForm for use with the RadGrid.  When I edit or insert a record, the other records in the grid display incorrectly.  

My app:
- simple ASP.NET 4.5 web application
- OS: Windows 8.1
- IDE: VS2013.  
- Telerik version - I am a consultant and using the DLLs provided by my client, so I don't have any sort of Telerik SDK installed.  The version of Telerik.Web.UI.dll I am using is 2013.1.417.35 (17MB, dated 5/12/2014 7:50pm).
- Browser: Google Chrome Version 36.0.1985.125 m.  I also tested on IE 11 11.0.9600.17207 (Update version 11.0.10).

<%@ Page Language="C#" AutoEventWireup="true" CodeFile="TestGrid.aspx.cs" Inherits="TestGrid" %>
<%@ Register Assembly="Telerik.Web.UI" Namespace="Telerik.Web.UI" TagPrefix="telerik" %>
<!DOCTYPE html>
<html xmlns="">
<head runat="server">
    <form id="form1" runat="server">
        <telerik:RadScriptManager runat="server" ID="RadScriptManager1" />
        <telerik:RadAjaxManager ID="RadAjaxManager1" runat="server">
                <telerik:AjaxSetting AjaxControlID="dataGrid">
                        <telerik:AjaxUpdatedControl ControlID="dataGrid" LoadingPanelID="RadAjaxLoadingPanel1"/>
                        <telerik:AjaxUpdatedControl ControlID="divMsgs" />
        <telerik:RadAjaxLoadingPanel ID="RadAjaxLoadingPanel1" runat="server" />
            <telerik:RadGrid runat="server" ID="dataGrid" AutoGenerateColumns="False" Width="300px">
                <MasterTableView DataKeyNames="Id" CommandItemDisplay="Top" EditMode="EditForms">
                        <telerik:GridEditCommandColumn />
                        <telerik:GridBoundColumn HeaderText="Id" DataField="Id" Display="False" UniqueName="Id" />
                        <telerik:GridBoundColumn HeaderText="Name" DataField="Name" UniqueName="Name" />
                        <telerik:GridBoundColumn HeaderText="Age" DataField="Age" UniqueName="Age" />
                    <EditFormSettings EditFormType="Template">
                                    <th colspan="2">Person Info</th>
                                        <td><asp:TextBox ID="tbName" runat="server" Text='<%# Bind("Name") %>' /></td>
                                        <td><asp:TextBox ID="tbAge" runat="server" Text='<%# Bind("Age") %>' /></td>
                                        <td align="right" colspan="2">
                                            <asp:Button ID="btnUpdate" runat="server" 
                                                Text='<%# (Container is GridEditFormInsertItem) ? "Insert" : "Update" %>'
                                                CommandName='<%# (Container is GridEditFormInsertItem) ? "PerformInsert" : "Update" %>' />
                                            <asp:Button ID="btnCancel" runat="server" 
                                                Text="Cancel" CausesValidation="False" CommandName="Cancel" />


using System;
using System.Collections;
using System.Diagnostics;
using Telerik.Web.UI;

public partial class TestGrid : System.Web.UI.Page {
    protected void Page_Load(object sender, EventArgs e) {
        dataGrid.NeedDataSource += dataGrid_NeedDataSource;
        dataGrid.InsertCommand += dataGrid_InsertCommand;
        dataGrid.UpdateCommand += dataGrid_UpdateCommand;

    void dataGrid_NeedDataSource(object sender, GridNeedDataSourceEventArgs e) {
        dataGrid.DataSource = People;

    public People People {
        get {
            var obj = this.ViewState["_people"];
            if (obj != null) return (People)obj;
            var people = People.AllPeople;
            this.ViewState["_people"] = people;
            return people;

    void dataGrid_UpdateCommand(object sender, GridCommandEventArgs e) {
        var values = new Hashtable();
        e.Item.OwnerTableView.ExtractValuesFromItem(values, e.Item as GridEditableItem);
        foreach (DictionaryEntry de in values) Debug.WriteLine("{0}={1}", de.Key, de.Value);
        this.ViewState["_people"] = People;

    void dataGrid_InsertCommand(object sender, GridCommandEventArgs e) {
        var values = new Hashtable();
        e.Item.OwnerTableView.ExtractValuesFromItem(values, e.Item as GridEditableItem);
        this.ViewState["_people"] = People;


using System;
using System.Collections;
using System.Collections.Generic;
using System.Linq;

public class Person {
    static int _nextId;

    private int m_id;

    public int Id {
        get { return m_id; }
        set { 
            m_id = value;
            _nextId = Math.Max(m_id + 1, _nextId);

    public string Name { get; set; }
    public int Age { get; set; }
    public Person(int id, string name, int age) {
        Id = id;
        Name = name;
        Age = age;
    public Person() {}
    public void AssignId() {
        Id = _nextId;

    public override string ToString() {
        return string.Format("#{0}: {1} [{2}]", Id, Name, Age);

    public void Update(Hashtable values) {
        Name = (string)values["Name"];
        Age = int.Parse((string)values["Age"]);

public class People : List<Person> {
    public People() {
        Add(new Person(1, "David", 43));
        Add(new Person(2, "Rebecca", 40));
    public void UpdatePerson(Hashtable values) {
        var person = this.FirstOrDefault(p => p.Id == int.Parse((string)values["Id"]));
        if (person == null) throw new NullReferenceException("Person not found (" + values["Id"] + ")");
    public void AddPerson(Hashtable values) {
        var person = new Person();

    static People s_people;
    public static People AllPeople { get { return s_people ?? (s_people = new People()); } }

I have attached three files:
- Pic1.png: Viewing the data (works fine)
- Pic2.png: Edit the "David" record
- Pic3.png: Insert a new record

I tried viewing source after clicking Insert, but it appears that source in that case is simply the source I see when I view the data.  The custom edit form controls don't appear in that source. 

Note that this is the same behavior as in this post: 

2 Answers, 1 is accepted

Sort by
Angel Petrov
Telerik team
answered on 31 Jul 2014, 12:42 PM
Hello David,

Actually after running the provided code I noticed that the Id of the person was not passed to the UpdatePerson method which was causing an exception to be thrown. After modifying the code logic like demonstrated below I was able to make things work correctly.

void dataGrid_UpdateCommand(object sender, GridCommandEventArgs e)
       var values = new Hashtable();
       e.Item.OwnerTableView.ExtractValuesFromItem(values, e.Item as GridEditableItem);
       GridEditableItem editItem = e.Item as GridEditableItem;
       values["Id"] = editItem.GetDataKeyValue("Id").ToString();
       this.ViewState["_people"] = People;

In attachments you can find the sample website that I have used for testing. It seems to perform the update and insert operations as expected. By modifying the code logic as demonstrated in the attached project you should be able to resolve the problem.

Angel Petrov

Check out the Telerik Platform - the only platform that combines a rich set of UI tools with powerful cloud services to develop web, hybrid and native mobile apps.

Top achievements
Rank 1
answered on 31 Jul 2014, 01:26 PM
Now when I open the solution up (the same one I copied that code from) and run it, it works fine.  And that's without making the change you mentioned.  So I'm not sure what's going on or what happened, but either way it's working for me.  Thanks for replying!
Asked by
Top achievements
Rank 1
Answers by
Angel Petrov
Telerik team
Top achievements
Rank 1
Share this question