This is a migrated thread and some comments may be shown as answers.

Invalid CSS generated for controls without gradient

4 Answers 32 Views
General Discussions
This is a migrated thread and some comments may be shown as answers.
René
Top achievements
Rank 2
René asked on 23 Oct 2018, 10:30 AM

Hello,

there is a bug with linear-gradient mixin. When no gradient is defined, invalid css is generated.

For example:

Upload.Bootstrap.scss

// ProgressBar
.ruFileProgressWrap {
    background-color: $progress-bg;
    background-image: linear-gradient($progress-gradient);
    border-radius: 2px;
}

results in

.RadUpload_Bootstrap .ruFileLI .ruFileProgressWrap {
  background-color: whitesmoke;
  background-image: linear-gradient();
  border-radius: 2px; }

So background-image value is invalid and should be "none"

.RadUpload_Bootstrap .ruFileLI .ruFileProgressWrap {
  background-color: whitesmoke;
  background-image: none;
  border-radius: 2px; }

 

This is problem in source files, Skin builder generates the same files etc. When this css is passed for some postprocessing in build process (postcss and autoprefixer for example), it fails.

 

Best Regards

René

4 Answers, 1 is accepted

Sort by
0
Ivan Zhekov
Telerik team
answered on 26 Oct 2018, 08:05 AM
Hi, Rene.

We are aware of that behaviour. In previous versions of our sass compiler passing null value would not generate the line. However, that's not the case for a while.

We are going to improve on that behaviour by using a different approach in which the value is checked for null before the line is generated.

Regards,
Ivan Zhekov
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
0
René
Top achievements
Rank 2
answered on 14 Nov 2019, 08:32 AM

Hello,

still not fixed in Telerik_UI_for_ASP.NET_AJAX_2019_3_1023_Source?

 

Regards

René

0
Rumen
Telerik team
answered on 18 Nov 2019, 02:08 PM

Hi René,

Thank you for checking up what is happening with this issue.

After a detailed research it appeared that this small change will impact the architecture of the Telerik AJAX skinning and may cause unwanted side effects and regressions.

The demand for this fix is low, that's why we decided to postpone it in favor of other highly demanded features and more important bugs. If you'd like you can log it in the feedback portal so  that more developers vote for its fixing. I also updated your Telerik points for reporting.

Regards,
Rumen
Progress Telerik

Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
0
René
Top achievements
Rank 2
answered on 18 Nov 2019, 05:45 PM

Hello,

we are building custom skins from source scss and this causes problems because PostCSS is unable to process generated files because some selectors are invalid. We have to modify files always to get failed build to work.

But I understand it is not critical priority. Still it should be fixed :-)

Regards

René

Tags
General Discussions
Asked by
René
Top achievements
Rank 2
Answers by
Ivan Zhekov
Telerik team
René
Top achievements
Rank 2
Rumen
Telerik team
Share this question
or