IHostingEnvironment is obsolete

[Jimmy]

IHostingEnvironment used in FileManager is long obsoleted. 

Any plan to upgrade to IWebHostEnvironment soon?

thank you. 

[Ianko]

Hi Jimmy,

You are not limited to use the built-in controller to use the FileManager. The demos (https://demos.telerik.com/aspnet-core/filemanager) have been updated with detailed code to see how you can have your own controller and thus use the IWebHostEnvironment  interface instead of the IHostingEnvironment one.

Regards,
Ianko
Progress Telerik

[Nicolas]

This answer is halfway correct as Telerik (2022.3.913) ImageBrowser is still using the IHostingEnvironment for the interface IDirectoryBrowser

namespace Kendo.Mvc.UI
{
    public interface IDirectoryBrowser
    {
        IHostingEnvironment HostingEnvironment { get; set; }

        IEnumerable<FileBrowserEntry> GetFiles(string path, string filter);

        IEnumerable<FileBrowserEntry> GetDirectories(string path);
    }
}

By overwriting with the following

public interface IDirectoryBrowser
{
    IWebHostEnvironment HostingEnvironment { get; set; }
    IEnumerable<FileBrowserEntry> GetFiles(string path, string filter);
    IEnumerable<FileBrowserEntry> GetDirectories(string path);
}

we again have an issue where

private readonly IDirectoryBrowser directoryBrowser

directoryBrowser stay null therefore not accessing the directory (path issue) unless we do this which is then still using obsolete feature

protected BrowserBaseFileController(
        IDirectoryBrowser directoryBrowser,
        IDirectoryPermission permission,
        IWebHostEnvironment hostingEnvironment)
    {
        this.directoryBrowser = directoryBrowser;
        this.directoryBrowser.HostingEnvironment = (Microsoft.AspNetCore.Hosting.IHostingEnvironment)hostingEnvironment;
        this.permission = permission;
        this.HostingEnvironment = hostingEnvironment;
    }

Thanks for the feedback on how or when this be fixed.

 

[Alexander]

Hi Nicolas,

Thank you for the provided feedback, it is not taken for granted. I will forward your feedback to our team to ensure your point of view is taken into account.