This is a migrated thread and some comments may be shown as answers.

pull request for german globalization

3 Answers 11 Views
Globalization
This is a migrated thread and some comments may be shown as answers.
marcus
Top achievements
Rank 2
marcus asked on 04 Sep 2018, 06:02 AM

Hello,

i made some changes for the german localisation in the telerik/kendo-ui-core on github.

I have two open pull requests and want to know in what time frame they are handled usually.

Sadly one of the requests failed with an timeout error(?) is there a way to get more details on the error?

We use git at the office all the time but i'm new to github an the hole pull request thing :) 

 

Kind Regards,

Marcus Labohm

3 Answers, 1 is accepted

Sort by
0
Ivan Danchev
Telerik team
answered on 06 Sep 2018, 05:49 AM
Hello Marcus,

While the time frame for merging pull requests is not set stone we try to do it without significant delays. However for a pull request to be merged the contributor must have signed our CLA first. Please sign it and post a comment in the pull request.

As for the failed check for one of the pull request, I was not able to get any useful information from the exception on why the build failed, but I restarted it and the checks passed successfully, which means the issue was on our end and everything is alright with your commit.

Regards,
Ivan Danchev
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
0
marcus
Top achievements
Rank 2
answered on 06 Sep 2018, 11:19 AM

Hello Ivan,

thanks for the answer. I signed the CLA and posted a comment :)

Kind Regards,

Marcus

0
Ivan Danchev
Telerik team
answered on 10 Sep 2018, 06:59 AM
Hello Marcus,

Thank you for your contribution. I am writing to inform you that we will delay merging your pull request a little bit. Our release is due later this week and for stability purposes we have stopped merging pull requests until the release becomes live. We will merge the pull request afterwards.

Regards,
Ivan Danchev
Progress Telerik
Get quickly onboarded and successful with your Telerik and/or Kendo UI products with the Virtual Classroom free technical training, available to all active customers. Learn More.
Tags
Globalization
Asked by
marcus
Top achievements
Rank 2
Answers by
Ivan Danchev
Telerik team
marcus
Top achievements
Rank 2
Share this question
or