This is a migrated thread and some comments may be shown as answers.

IDataItem should not be "internal"

2 Answers 12 Views
General Discussions
This is a migrated thread and some comments may be shown as answers.
Olivier
Top achievements
Rank 1
Olivier asked on 30 Jun 2020, 02:42 PM

Hi,

I'm not reporting an issue here, just making a suggestion about a minor change that I would consider as an improvement.

I'm loading at runtime a report template that was created using the standalone report designer. I'm dynamically replacing all the 'DataSources' of the report, and thus I have to go through all the items of the report to find them all.

The first step is to flatten all the items with a recursive call, starting from the 'Report'. I get a list of ReportItem, and I can cycle through this list and find those that inherits from 'DataItem'. From there, I just have to pick all the distinct DataSources from these DataItems.

And it almost works, except that I'm missing the DataSource from the Report itself, as the Report class does not inherit from DataItem but implements IDataItem.

If IDataItem was public, I could simply use it instead of 'DataItem', but as it is internal I have to handle a special case. And I don't like that.

Maybe I'm missing a good reason to keep this interface internal, but if not my suggestion is to make it public.

Regards,

Olivier

2 Answers, 1 is accepted

Sort by
0
Accepted
Katia
Telerik team
answered on 03 Jul 2020, 11:23 AM

Hi Olivier,

Thank you for sharing your idea!

We consider it as a valid feature request and we logged it into our Feedback portal here - https://feedback.telerik.com/reporting/1474713-make-idataitem-interface-public. This is the official process for keeping track of all feature requests and accessing the demand for them.

 

Regards,
Katia
Progress Telerik

Progress is here for your business, like always. Read more about the measures we are taking to ensure business continuity and help fight the COVID-19 pandemic.
Our thoughts here at Progress are with those affected by the outbreak.
0
Olivier
Top achievements
Rank 1
answered on 03 Jul 2020, 01:59 PM

Hi Katia,

Thank you for your answer, and also for the information about the feedback portal.

Regards,

Olivier

Tags
General Discussions
Asked by
Olivier
Top achievements
Rank 1
Answers by
Katia
Telerik team
Olivier
Top achievements
Rank 1
Share this question
or