Errors in French resources

5 posts, 0 answers
  1. Patrick
    Patrick avatar
    498 posts
    Member since:
    Aug 2012

    Posted 26 Jun Link to this post

    Hello,

    The following resources are wrong in French:

    • FileDialogs_FileSizes_B, should be "octets" instead of "bytes".
    • FileDialogs_FileSizes_GB, should be "Go" instead of "GB".
    • FileDialogs_FileSizes_KB, should be "ko" instead of "KB".
    • FileDialogs_FileSizes_MB, should be "Mo" instead of "MB".
    • FileDialogs_FileSizes_TB, should be "To" instead of "TB".
    • FileDialogs_OpenFolderDialogHeader, should be "Sélectionner un dossier" instead of "Ouvrir le dossier".
    • FileDialogs_OpenFolder, should be "Sélectionner le dossier" instead of "Ouvrir le dossier".
    • FileDialogs_DateHeader: should be "Modifié le" instead of "Date de modification ".
    • FileDialogs_Back, should be "Précédent" instead of "Retour".
    • FileDialogs_Forward, should be "Suivant" instead of "Transférer".
    • FileDialogs_Up, should be "Dossier parent " instead of "En haut".
    • FileDialogs_CopyTo: should be "Copier sur" instead of "Copier a". (there's a typo in "Copier a", as the "a" must take a grave accent in this case: "à").
    • FileDialogs_MoveTo: should be "Déplacer vers " instead of "Déplacer".

    Note for English:

    • The official SI abbreviation for "kilo" is a lowercase "k", not an uppercase one, so it should be "kb" in English, not KB, and so on.
    • For the RadOpenDialogFolder, we don't "open" a folder, but "select" it, This should be changed in the resources, but also in the documentation (and even in the class name!).

    It's also strange that the FileDialogs_InvalidOrMissingExtension resource says something completely different: "If you change a file name extension, the file might become unusable". Some thing for the FileDialogs_InvalidExtensionConfirmation resource.

  2. Martin Ivanov
    Admin
    Martin Ivanov avatar
    2520 posts

    Posted 01 Jul Link to this post

    Hello Patrick,

    Thank you for the provided information. I will check this and get back to you with more information on the topic.

    Regards,
    Martin Ivanov
    Progress Telerik

    Progress is here for your business, like always. Read more about the measures we are taking to ensure business continuity and help fight the COVID-19 pandemic.
    Our thoughts here at Progress are with those affected by the outbreak.
  3. Martin Ivanov
    Admin
    Martin Ivanov avatar
    2520 posts

    Posted 02 Jul Link to this post

    Hello Patrick,

    This is some great feedback. You can find your Telerik points updated as a small gesture of gratitude for spending your time to share this information.

    I've researched this and here are my findings. RadFileDialogs are based mainly on the Windows Explorer, Windows save/open dialogs and the Visual Studio save/open dialogs. Here is some information for the specific strings:

    • FileDialogs_FileSizes_B, should be "octets" instead of "bytes".
    • FileDialogs_FileSizes_GB, should be "Go" instead of "GB".
    • FileDialogs_FileSizes_KB, should be "ko" instead of "KB".
    • FileDialogs_FileSizes_MB, should be "Mo" instead of "MB".
    • FileDialogs_FileSizes_TB, should be "To" instead of "TB".

      Those suggestions seems correct. There are only two small notes on the translations. I've checked this and in French - France culture in Windows dialogs, and the KB is "Ko" with capital "K". Additionally, "octets" has the "s" in brackets - "octet(s)" Can you confirm this or I am missing something?
    • FileDialogs_OpenFolderDialogHeader, should be "Sélectionner un dossier" instead of "Ouvrir le dossier".
    • FileDialogs_OpenFolder, should be "Sélectionner le dossier" instead of "Ouvrir le dossier".

      Those two strings are based on the Visual Studio's open folder dialogs. In English the dialogs state "Select a folder", instead of "Open a folder".
    • FileDialogs_Up, should be "Dossier parent " instead of "En haut".

      On my Windows dialogs this option says "Jusqu'à". Is this correct?
    • FileDialogs_CopyTo: should be "Copier sur" instead of "Copier a". (there's a typo in "Copier a", as the "a" must take a grave accent in this case: "à").

      On my Windows dialogs this options says "Copier ici". Is this correct?
    • FileDialogs_MoveTo: should be "Déplacer vers " instead of "Déplacer".

      On my Windows dialogs this options says "Déplacer ici". Is this correct?

      The following three corrections seems okay. We will review and consider updating them.
    • FileDialogs_DateHeader: should be "Modifié le" instead of "Date de modification ".
    • FileDialogs_Back, should be "Précédent" instead of "Retour".
    • FileDialogs_Forward, should be "Suivant" instead of "Transférer".

    About the English notes:

    • The official SI abbreviation for "kilo" is a lowercase "k", not an uppercase one, so it should be "kb" in English, not KB, and so on.

      RadFileDialogs mimic Windows/Visual Studio dialogs where the kilobyte is abbreviated as KB. Currently, there is no plan to alter this. However, you can alter this text by creating a custom localization manager and overriding the corresponding localization values.
    • For the RadOpenDialogFolder, we don't "open" a folder, but "select" it, This should be changed in the resources, but also in the documentation (and even in the class name!).

      I can agree with that the naming can be improved. However, changing the class name and resources will cause a breaking change that we prefer to avoid. Also, the naming of the class is based on the OpenFileDialog .NET API. RadOpenFolderDialog uses similar name in order to be more recognizable compared to the already existing .NET API.
    • It's also strange that the FileDialogs_InvalidOrMissingExtension resource says something completely different: "If you change a file name extension, the file might become unusable". Some thing for the FileDialogs_InvalidExtensionConfirmation resource.

      This is also based on the Windows Explorer behavior. The InvalidOrMissingExtension message shows only when you rename a file and delete its extension. The message states that if you remove the extensions, the file may become unusable. Both InvalidOrMissingExtension and  InvalidExtensionConfirmation resources are shown in the same prompt dialog.

    Regards,
    Martin Ivanov
    Progress Telerik

    Progress is here for your business, like always. Read more about the measures we are taking to ensure business continuity and help fight the COVID-19 pandemic.
    Our thoughts here at Progress are with those affected by the outbreak.
  4. Patrick
    Patrick avatar
    498 posts
    Member since:
    Aug 2012

    Posted 02 Jul in reply to Martin Ivanov Link to this post

    Hi Martin,

    First, for your information, French is my mother tongue, so it's why I'm sending these corrections.

    1. For "Ko" vs "ko", look at this Wikipedia page https://fr.wikipedia.org/wiki/Kilo (English page: https://en.wikipedia.org/wiki/Kilo-). Here you can find that, officially, the symbol for "kilo" is a lowercase "k"
    There is also a distinction between a kilobit, which is 1000 bits and a kibibit, which is 1024 bits (French page: https://fr.wikipedia.org/wiki/Kilobit, English page: https://en.wikipedia.org/wiki/Kilobit). Even Windows Explorer is wrong, because it says "kilobyte" for 1024 bytes, that explains why a 1TB hard disk has only about 935MB free in Windows.

    2. "octet(s)" vs "octets". It's as in English: if you want to be purist, you should write "octet" if there is only one and "octets" if the are at least two.

     

    3. I've written long time ago a method to format correctly the size of a file and just corrected it for .NET Core, with all the remarks above. The wanted format is a parameter, or a default value that can be defined application-wide.

     

    4. "Open folder" vs "Select folder". To be correct (at least in French), we don't open (ouvrir) a folder, but we select it in order to load or save file in it. Word 2019 uses "Changer le dossier" (Change folder), saying that we change where the files are. LibreOffice uses "Select folder".

     

     

    5.  FileDialogs_Up: Windows Explorer displays ""Up to" (jusqu'à) followed by the name of the folder. If you don't display the name of the folder, it's more correct to talk to "Parent folder" (dossier parent).

     

    6. FileDialogs_MoveTo: it depends on the exact phrase. If you follow the text with the name of the folder, it is "Déplacer vers" (move to); if the folder name is not appended, it is "Déplacer" (move).

     

    7. "KB" vs "kb" in English: I've already corrected this on my side.

     

    8. "open folder" vs "select folder", event if you don't change the class name, you could change the resources. Another possibility would be to define a class alias, so both names are correct.

     

    9. FileDialogs_InvalidOrMissingExtension: the name says "Invalid" or "Missing", but the text shows a warning, no something about an invalid or missing extension. If we change the extension, it is not always invalid. Why not name the resource ChangeExtensionConfirmation?

  5. Martin Ivanov
    Admin
    Martin Ivanov avatar
    2520 posts

    Posted 07 Jul Link to this post

    Hello Patrick,

    That is some great feedback. Thank you for sharing it. We will consider improving this.

    Regards,
    Martin Ivanov
    Progress Telerik

    Progress is here for your business, like always. Read more about the measures we are taking to ensure business continuity and help fight the COVID-19 pandemic.
    Our thoughts here at Progress are with those affected by the outbreak.
Back to Top