Border of disabled TextBox in Office2013 theme

[Patrick]

Hello,
When a TextBox is disabled in the Office2013 theme, the border is no more visible.
Patrick

[Vanya Pavlova]

Hi Patrick,


I've tried to replicate the same behavior, however to no avail. 
May you verify whether you have merged Office2013ResourceDictionary in App.xaml?:

<Application x:Class="TextBoxDisabled.App"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
              xmlns:telerik="http://schemas.telerik.com/2008/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             StartupUri="MainWindow.xaml">
    <Application.Resources>
        <ResourceDictionary>
            <ResourceDictionary.MergedDictionaries>
                <telerik:Office2013ResourceDictionary/>
                <ResourceDictionary Source="System.Windows.xaml"/>
            </ResourceDictionary.MergedDictionaries>
        </ResourceDictionary>
    </Application.Resources>
</Application>

I'm attaching you small sample demo, that I used for testing purposes. 
Would it be possible to take a look at the attachment and let us know how it differs from yours? 

Any additional version about the version you used will be highly appreciated, as well. 


Regards,
Vanya Pavlova
Telerik

 

 

[Patrick]

Hello Vanya,
I can not reproduce it with your example, but I see it in my application.
The main differences are that my control is inside a document pane that is part of a docking, that the enable/disable is made using a button and that the data context is changed by code after the control is displayed.
I will make tests to look at the condition that makes the problem and add a new reply.
Patrick

[Patrick]

Hello Vanya,
here is a test case that reproduce the problem.
The main difference is that I have loaded the resources as specified in the documentation:

<ResourceDictionary.MergedDictionaries>
  <ResourceDictionary Source="/Telerik.Windows.Themes.Office2013;component/Themes/System.Windows.xaml"/>
</ResourceDictionary.MergedDictionaries>

What is the purpose of the <telerik:Office2013ResourceDictionary/> resource specification?
It is mentionned nowhere in the documentation!!!!

Even adding it to my test case, the border is not displayed!
But the border is displayed when you click on the TextBox.

Patrick

[Patrick]

Vanya,
just something that could be important: you were using version 2014.1.224.45 of the Telerik controls and I am using version 2014.1.331.45.
I will create a support ticket for the test case.
Patrick

[Vanya Pavlova]

Hello Patrick,


As a kind of follow up, I've updated the project you have already sent. Indeed, there is a difference between these versions. Actually we are talking about the IsReadOnly state of the TextBox, not about the disabled one. Looking back, we had an internal discussion and designer's review of this theme and the IsReadOnly state of the TextBox was changed, following the design guideline. When the TextBox enters this state the outer border of this element should not be visible to the end-user and that should be the expected behavior. 



Regards,
Vanya Pavlova
Telerik

 

 

[Patrick]

Vanya,
the result of this change is not good: the TextBox control has no border, but other controls, such as DateTimePicker or ComboBox, that must be disabled, have a border. That doesn't look good.
Patrick

[Vanya Pavlova]

Hi Patrick,


We had the same discussion on that matter. If you remove the outer Border of RadDateTimePicker and RadComboBox in ReadOnly state it's strange, indeed.
We finally decided to keep the behavior, which is by design. 
Any attempt to revert back these changes could lead to a potential breaking change, that we want to avoid. 

Currently, if you need this Border, I may suggest you to modify the template of TextBox against Office2013
theme and remove the animation that resets the BorderThickness of the root container. 
Hope this helps. 


Regards,
Vanya Pavlova
Telerik

 

 

[Patrick]

Hello Vanya,
look at this screen shot to see how it looks bad when you mix a read-only TextBox to other controls.
The TextBox is read-only, because this lets the user select the content to copy it.
Patrick

[Vanya Pavlova]

Hello Patrick,



Thank you for the followup. I will forward your feedback to our developers for further investigation. 


Regards,
Vanya Pavlova
Telerik