This is a migrated thread and some comments may be shown as answers.

Missing Localization in ColorPicker

7 Answers 10 Views
ColorPicker
This is a migrated thread and some comments may be shown as answers.
Bernd
Top achievements
Rank 2
Bernd asked on 08 Feb 2018, 10:11 AM

Dear Telerik team.

Would it be possible for you to localize the five messages of the color picker widget?

It is pretty annoying to handle several languages by setting the color picker message option on every usage.

Or tell us what changes in the messages file are needed to have only one place to modify.

Kind regards

Bernd

7 Answers, 1 is accepted

Sort by
0
Joana
Telerik team
answered on 12 Feb 2018, 05:19 AM
Hello Bernd,

We are aware that there are missing localization for certain messages among the widgets. Could you please specify what is incorrectly localized so that we could review it on our side? However, you could create a custom localization file that is to be included in the page with all changes per the colorpicker there. Have a look at the following localization articles where it is described how to create such file and its configuration: https://docs.telerik.com/kendo-ui/framework/localization/overview.

Regards,
Joana
Progress Telerik
Try our brand new, jQuery-free Angular components built from ground-up which deliver the business app essential building blocks - a grid component, data visualization (charts) and form elements.
0
Bernd
Top achievements
Rank 2
answered on 13 Feb 2018, 12:02 PM

Hi Joana.

None of the four messages seem to be translated into German. Taken from kendo.colorpicker.js.

MESSAGES = {
                apply: 'Apply',
                cancel: 'Cancel',
                noColor: 'no color',
                clearColor: 'Clear color',
                previewInput: 'Color Hexadecimal Code'
0
Bernd
Top achievements
Rank 2
answered on 13 Feb 2018, 12:56 PM

Adding the code below to the kend.messages.de-DE.js did the trick. Could you add the translations to the next release?

/* FlatColorPicker messages */
 
if (kendo.ui.FlatColorPicker) {
    kendo.ui.FlatColorPicker.prototype.options.messages =
    $.extend(true, kendo.ui.FlatColorPicker.prototype.options.messages, {
        "apply": "Anwenden",
        "cancel": "Abbrechen",
        "noColor": "keine Farbe",
        "clearColor": "Farbe löschen"
    });
}
 
/* ColorPicker messages */
 
if (kendo.ui.ColorPicker) {
    kendo.ui.ColorPicker.prototype.options.messages =
    $.extend(true, kendo.ui.ColorPicker.prototype.options.messages, {
        "apply": "Anwenden",
        "cancel": "Abbrechen",
        "noColor": "keine Farbe",
        "clearColor": "Farbe löschen"
    });
}
0
Joana
Telerik team
answered on 15 Feb 2018, 09:27 AM
Hello Bernd,

I am glad that you have updated the localization files to contain the messages for ColorPicker.

All translations are available in our Kendo UI Core repository: https://github.com/telerik/kendo-ui-core/tree/master/src/messages. If you find more missing messages feel free to fork our repository, apply the changes in the respective files and submit a pull request: https://github.com/telerik/kendo-ui-core/blob/master/CONTRIBUTING.md#3-submit-a-pull-request. We will include the provided translations for the next Kendo UI release.

Regards,
Joana
Progress Telerik
Try our brand new, jQuery-free Angular components built from ground-up which deliver the business app essential building blocks - a grid component, data visualization (charts) and form elements.
0
Bernd
Top achievements
Rank 2
answered on 15 Feb 2018, 01:03 PM

Hi Joana.

Thanks for pointing me to the github repo. According to your contribution policy I need to create tests. Well, looking at your tests I can't see any tests for the localizations. So what do you expect me to test?

Thanks
Bernd

0
Joana
Telerik team
answered on 16 Feb 2018, 03:32 AM
Hello Bernd,

There is no need for tests for the localization messages. After submitting a pull request we will review it and reach out to you if changes/tests are required or we will handle it by ourselves. Here is the Contribution section for localization in our documentation: https://docs.telerik.com/kendo-ui/framework/localization/overview#contribution.

I have updated your Telerik points for your contribution.

Regards,
Joana
Progress Telerik
Try our brand new, jQuery-free Angular components built from ground-up which deliver the business app essential building blocks - a grid component, data visualization (charts) and form elements.
0
Bernd
Top achievements
Rank 2
answered on 16 Feb 2018, 08:57 AM
Thank you. Pull request submitted.
Tags
ColorPicker
Asked by
Bernd
Top achievements
Rank 2
Answers by
Joana
Telerik team
Bernd
Top achievements
Rank 2
Share this question
or