Latest build broke the combobox in the grid?

[Deborah]

We put the latest build (Q3) on a few weeks ago. Now all of our comboboxes in the grids stopped working. I did not put on the Q2 version back on to confirm, but I (and my other team members) thought they worked in Q2.

Here is what happens:

1) User drops down a combobox in the grid.
2) User selects an entry from the combobox.
3) THE COMBO BOX DOES NOT CLOSE

Can anyone confirm this? Will there be a fix to this soon? Or do I have to write code in every one of our forms to manually close the combobox? If I have to write code, anyone know what that code would look like?

Thanks for any tips!

[Richard Slade]

Hi Deborah,

Hope you're well. I've tried this as a basic example and I haven't been able to replicate this. Please could you try the following code in a new project. It's just a RadGridView on a form.

Imports Telerik.WinControls
Imports Telerik.WinControls.UI

Public Class Form1

    Private Sub Form1_Load(ByVal sender As System.Object,
                           ByVal e As System.EventArgs) Handles MyBase.Load


        Dim people As New List(Of Person) From {New Person(1, "Richard"), New Person(2, "Peter"), New Person(3, "Chris")}

        Dim column As New GridViewComboBoxColumn("B")
        column.DataSource = people
        column.DisplayMember = "Name"
        column.ValueMember = "Id"

        Me.RadGridView1.Columns.Add(New GridViewTextBoxColumn("A"))
        Me.RadGridView1.Columns.Add(column)
        Me.RadGridView1.AllowAddNewRow = False

        Dim rowInfo As GridViewRowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "A1"
        rowInfo.Cells(1).Value = 1
        rowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells("A").Value = "A2"
        rowInfo.Cells("B").Value = 2

    End Sub


End Class

Public Class Person

    Public Sub New(ByVal Id As Integer, ByVal Name As String)
        Me.Name = Name
        Me.Id = Id
    End Sub

    Public Property Name As String
    Public Property Id As Integer

End Class

Let me know how it goes.
Richard

[Deborah]

OK, so there is something else going on here.

Your "simple" example works. But at least two of ours do not. (Though we all swear that they did before we put on Q3.)

I even replaced the grid in your example with our grid user control and it still worked.

Any thoughts on what could be causing this not to work in our application?

[Richard Slade]

Hi again,

Are you perhaps handling any of the editor initialized events that might be affecting it? If not, I'll try running some tests but it would be useful if you could post some code that replicates the issue.

Regards,
Richard

[Deborah]

I tried commenting out all code in any grid events on one of our dialogs, no change.

I have not been able to come up with changes to your sample code that reproduces the problem.

So the only place we are seeing it is in our applications. And with all of its base classes and business objects, it will be hard to extract one of the dialogs that does not work in such a way that it can be easily tried by someone else.

I can post some screen shots if that would help ...

[Deborah]

I worked with your sample code until I got it to happen. Is there a place I can post a zip file or something so you can take a look?

I attached it here. Please change the extension from .jpeg to .zip and unzip it. Let me know if you see the same issue.

[Richard Slade]

Hi,

I'll see if I can replicate it in any way. You said you have disabled the grid events, what about any events that are fired on the drop down, a selected changed event perhaps?
Richard

[Richard Slade]

Hi Deborah,

I'm afraid I haven't been able to reproduce this and even if I could, I cannot be sure that it would be the same case as your situation. Do you have any events tied up with the combobox itself? If you can reproduce it in a sample, I'll happily take a look, but at this time I can't imagine another situation other than those that I've described why you might be getting the drop down staying open at the moment. I'll continue to look for you when I can and let you know. If you can provide any more information to help solve the issue, please let me know.

Kind regards,
Richard

[Deborah]

Yes. I did a sample. I posted in in my prior reply. (I had to define it as a jpeg to post it, but it is a zip file.)

The sample has several things:
1) It uses a rad form.
2) It includes a panel. (I was not able to reproduce it without the panel).
3) It includes our radGridView control that we built based on all of the other issues that I had that required subclassing the GridView.

Please let me know if you have any problems with the code.

[Richard Slade]

Hi Deborah,

There is no attachment. You can only post images here on the forum. Code has to be formatted and added via the reply itself.
Post whatever you can and I'll have a look as soon as possible (though it will have to be in the morning now as it's nearly midnight here)
Look forward to hearing from you.
Richard

EDIT// If you have a public area you can put it on, I'll download it.
Thanks

[Deborah]

I'm in the US so it will be Thanksgiving tomorrow ... no work! :-)

I will have to find a place to post it when I come back in on Friday.

Good night!

[Emanuel Varga]

Hello guys,

Someone else complained about this problem in the Q2 version if I'm not mistaken i was not able to reproduce the issue then, and i cannot reproduce it now, please take a look at this thread for a workaround to this issue.

Hope this helps, if you have any other questions or comments, please let me know,

Best Regards,
Emanuel Varga

Telerik WinForms MVP

[Richard Slade]

Hi Emanuel,

Thanks, that was good that you remembered that.
Deborah, if this solves your issue, please mark Emanuel's suggestion as answer. Otherwise, if you post your replica project when you get back, I can take a look for you.

Kind regards,
Richard

[Deborah]

OK, posted this part to the wrong thread.

Emanuel's suggestion seems to take care of the problem ... but I am not marking this as the answer because I am hoping that Telerik will actually fix the problem so this won't be necessary. Please let me know if you are able to reproduce the issue with the code I provided above.

[Richard Slade]

Hi Deborah,

There was no code above to try.
Regards,
Richard

[Deborah]

Hmmm. My whole post did not show up with the details on how to reproduce the problem and the code. Bummer.

I don't have the code here, so I will have to wait until I get to work tomorrow and try reposting then.

[Richard Slade]

Hi Deborah,

I understand that you now have a workaround as provided by Emanuel. I'd advise to mark this as answer so others can find the solution too. As far as I'm aware, marking an answer will not stop Telerik from fixing the issue, but it will help other users to find the solution whilst it is being fixed internally.

Best regards,
Richard

[Emanuel Varga]

Hello Deborah, Richard

This is starting to be strange, everyone is talking about different things:
@Deborah please post the small application whenever you have some time, just one big blob of text if you can, I'm very curios how this happens.
@Richard, it would be best if we were able to get to the bottom of the problem before we can hope for a fix and until the first sp there is still some time to wait.

Best Regards,
Emanuel Varga

Telerik WinForms MVP

[Richard Slade]

Hi All,

@Emanuel. Yes, of course it would be best to get to the bottom of it. Marking a workaround as answer doesn't stop either of us helping to find the cause of the issue.
@Deborah. I look forward to seeing the code posted. If I can help, I will.

regards,
Richard

[Deborah]

For some reason, the post I did on Friday with details on how to reproduce the problem and the code never showed up on this thread, so here it is again.

1) Add a RadGridView to a form.
NOTE: When I dragged and dropped a RadGridView from the toolbox onto a form in a new project (from the RadControls for WinForms Q3 2010 tab), the references were all set to the Q2 version. That is why I was not able to reproduce the problem when I first tried it with a new project. Please ensure that the references are set to the Q3 version.

2) Paste in this code.

Imports Telerik.WinControls.UI

Public Class Form1
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        With RadGridView1
            ' Set the desired default property values.
            ' Rows
            .AutoSizeRows = True
            .AllowRowResize = False
            .AllowRowReorder = False
            .EnableAlternatingRowColor = True
            .ShowRowHeaderColumn = False

            ' Columns
            .AutoGenerateColumns = False
            .AutoSizeColumnsMode = GridViewAutoSizeColumnsMode.None
            .AllowColumnChooser = False
            .AllowColumnResize = True
            .AllowColumnReorder = False
            .AllowDragToGroup = False

            ' Allow the user to directly edit the rows but not add or delete
            .AllowAddNewRow = False
            .AllowDeleteRow = False
            .AllowEditRow = True
            .EnterKeyMode = RadGridViewEnterKeyMode.EnterMovesToNextRow
            .AddNewRowPosition = Telerik.WinControls.UI.SystemRowPosition.Bottom

            ' Other
            .ShowGroupPanel = False
            .ShowItemToolTips = True
            .AutoScroll = True
        End With

        Dim people As New List(Of Person) From {New Person(1, "Richard"), New Person(2, "Peter"), New Person(3, "Chris")}

        Dim column1 As New GridViewTextBoxColumn("Column 1")
        column1.Width = 100

        Dim column2 As New GridViewComboBoxColumn("Column 2")
        column2.Width = 100
        column2.FieldName = "Id"
        column2.DataSource = people
        column2.DisplayMember = "Name"
        column2.ValueMember = "Id"

        Me.RadGridView1.Columns.Add(column1)
        Me.RadGridView1.Columns.Add(column2)

        ' Populate the cells
        Dim rowInfo As GridViewRowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "A1"
        rowInfo.Cells(1).Value = 1
        rowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells("A").Value = "A2"
        rowInfo.Cells("B").Value = 2
    End Sub
End Class

Public Class Person

    Public Sub New(ByVal Id As Integer, ByVal Name As String)
        Me.Name = Name
        Me.Id = Id
    End Sub

    Public Property Name As String
    Public Property Id As Integer
End Class

NOTE: This code is basically what Richard provided, but with some grid properties set that cause the problem to appear.

NOTE: This code WORKS correctly in the Q2 version, and DOES NOT WORK correctly in the Q3 version.

Please let me know if you don't see the issue.

[Richard Slade]

Hi Deborah, 

Hope you're well today. The problem line is this one

.AutoSizeRows = True

Here is the revised version. I will look into why this is happening

Imports Telerik.WinControls.UI

Public Class Form1
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        With RadGridView1
            ' Set the desired default property values.
            ' Rows
            '.AutoSizeRows = True
            .AllowRowResize = False
            .AllowRowReorder = False
            .EnableAlternatingRowColor = True
            .ShowRowHeaderColumn = False

            ' Columns
            .AutoGenerateColumns = False
            .AutoSizeColumnsMode = GridViewAutoSizeColumnsMode.None
            .AllowColumnChooser = False
            .AllowColumnResize = True
            .AllowColumnReorder = False
            .AllowDragToGroup = False

            ' Allow the user to directly edit the rows but not add or delete
            .AllowAddNewRow = False
            .AllowDeleteRow = False
            .AllowEditRow = True
            .EnterKeyMode = RadGridViewEnterKeyMode.EnterMovesToNextRow
            .AddNewRowPosition = Telerik.WinControls.UI.SystemRowPosition.Bottom

            ' Other
            .ShowGroupPanel = False
            .ShowItemToolTips = True
            .AutoScroll = True
        End With

        Dim people As New List(Of Person)
        people.Add(New Person(1, "Richard"))
        people.Add(New Person(2, "Peter"))
        people.Add(New Person(3, "Chris"))

        Dim column1 As New GridViewTextBoxColumn("Column 1")
        column1.Width = 100

        Dim column2 As New GridViewComboBoxColumn("Column 2")
        column2.Width = 100
        column2.FieldName = "Id"
        column2.DataSource = people
        column2.DisplayMember = "Name"
        column2.ValueMember = "Id"

        Me.RadGridView1.Columns.Add(column1)
        Me.RadGridView1.Columns.Add(column2)

        ' Populate the cells
        Dim rowInfo As GridViewRowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "A1"
        rowInfo.Cells(1).Value = 1
        rowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "A2"
        rowInfo.Cells(1).Value = 2
    End Sub
End Class

Public Class Person

    Private m_Name As String
    Private m_Id As Integer
    Public Sub New(ByVal Id As Integer, ByVal Name As String)
        m_Name = Name
        m_Id = Id
    End Sub

    Public Property Name() As String
        Get
            Return m_Name
        End Get
        Set(ByVal value As String)
            m_Name = value
        End Set
    End Property
    Public Property Id() As Integer
        Get
            Return m_Id
        End Get
        Set(ByVal value As Integer)
            m_Id = value
        End Set
    End Property
End Class

[Richard Slade]

Hi Deborah, 

I haven't yet found why AutoSizeRows is not working correctly but it does seem to be an issue with the way that the RadGridView is mis-calculating the row size when a GridViewComboBoxColumn is one of the columns. 

I would hope that this will be included as a fix in the upcoming service pack which is due out mid-December. Is AutoSize rows a property that you need at the moment? If so, I will do my best to look for another solution for you, but to me, the RadGridView looks incorrect as soon as the cell is in edit mode.(see attached - though you probably are well aware of how this looks already). 

Hope this helps somewhat, and when I have any more information for you, I'll let you know. 
Thanks
Richard

[Deborah]

Yes, we need to use AutoSizeRows because some of our grids have wrapped cells. If we don't have AutoSizeRows on, then the wrapping does not show correctly.

We are using the work around posted in the other thread that uses the CellEditorInitialized event to manually close the popup. But a fix would be much nicer.

NOTE: From a much earlier post, we built our own wrapper around the GridView to handle all of the other issues we have run across. As part of this wrapper, we use the ViewRowFormatting event to set a min and max height of each row to handle the other issue you saw ... which the row sizes are not calculated correctly. Here is the code:

Private Sub SCStarDataGrid_ViewRowFormatting(ByVal sender As Object, ByVal e As Telerik.WinControls.UI.RowFormattingEventArgs) Handles Me.ViewRowFormatting
    e.RowElement.RowInfo.MinHeight = 24
    e.RowElement.RowInfo.MaxHeight = 60
End Sub

I look forward to getting the fix for this issue whereby the drop down list/combo box in a GridView does not close when an entry is selected.

Thanks!

[Richard Slade]

Hi again, 

Ah, you beat me to it. I was just about to suggest setting a Min height for the rows. See below. Everything works fine like that. 

Imports Telerik.WinControls.UI

Public Class Form1
    Private Sub Form1_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        With RadGridView1
            ' Set the desired default property values.
            ' Rows
            .AutoSizeRows = True
            .AllowRowResize = False
            .AllowRowReorder = False
            .EnableAlternatingRowColor = True
            .ShowRowHeaderColumn = False

            ' Columns
            .AutoGenerateColumns = False
            .AutoSizeColumnsMode = GridViewAutoSizeColumnsMode.None
            .AllowColumnChooser = False
            .AllowColumnResize = True
            .AllowColumnReorder = False
            .AllowDragToGroup = False

            ' Allow the user to directly edit the rows but not add or delete
            .AllowAddNewRow = False
            .AllowDeleteRow = False
            .AllowEditRow = True
            .EnterKeyMode = RadGridViewEnterKeyMode.EnterMovesToNextRow
            .AddNewRowPosition = Telerik.WinControls.UI.SystemRowPosition.Bottom

            ' Other
            .ShowGroupPanel = False
            .ShowItemToolTips = True
            .AutoScroll = True
        End With

        Dim people As New List(Of Person)
        people.Add(New Person(1, "Richard"))
        people.Add(New Person(2, "Peter"))
        people.Add(New Person(3, "Chris"))

        Dim column1 As New GridViewTextBoxColumn("Column 1")
        column1.Width = 100

        Dim column2 As New GridViewComboBoxColumn("Column 2")
        column2.WrapText = True
        column2.FieldName = "Id"
        column2.DataSource = people
        column2.DisplayMember = "Name"
        column2.ValueMember = "Id"

        Me.RadGridView1.Columns.Add(column1)
        Me.RadGridView1.Columns.Add(column2)

        ' Populate the cells
        Dim rowInfo As GridViewRowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "Lorem ipsum dolor sit amet, consectetur adipisicing elit," & Environment.NewLine & "sed do eiusmod tempor incididunt ut labore" & Environment.NewLine & " et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat."
        rowInfo.Cells(1).Value = 1
        rowInfo.MinHeight = 25
        rowInfo = Me.RadGridView1.Rows.AddNew()
        rowInfo.Cells(0).Value = "A2"
        rowInfo.Cells(1).Value = 2
        rowInfo.MinHeight = 25
    End Sub

End Class

Public Class Person

    Private m_Name As String
    Private m_Id As Integer
    Public Sub New(ByVal Id As Integer, ByVal Name As String)
        m_Name = Name
        m_Id = Id
    End Sub

    Public Property Name() As String
        Get
            Return m_Name
        End Get
        Set(ByVal value As String)
            m_Name = value
        End Set
    End Property
    Public Property Id() As Integer
        Get
            Return m_Id
        End Get
        Set(ByVal value As Integer)
            m_Id = value
        End Set
    End Property
End Class

[Richard Slade]

Adding screenshot for above

[Deborah]

When you say "everything works fine", you don't mean that the combobox problem is fixed, correct?

We have the code that sets the row heights but the combobox still does not close when you pick an entry.

[Richard Slade]

Hi Deborah, 

Yes, I did mean that. Have you tried the code above as yet? The combo always closes when you select a new item in the multi column combo. 

Be interested to know the result. 
Richard

[Deborah]

All I did was add this line to my example:

rowInfo.MinHeight = 25

It did not fix the problem.

NOTE: I failed to mention in my prior post that the drop down list SOMETIMES closes correctly the first time you select something. But it does not then work the second or third time. When I added this line, I *was* able to pick something the first time and have it close. But when I opened it again to pick something else it again would not close.

[Richard Slade]

Hi Deborah,

I'm afraid I've left my laptop at work so I won't be able to look at it this evening. But from the tests that I tried, with the code that I posted above, it worked on every attempt. Can you confirm that you have tried my example above and it does not close the editor for you?
Thanks
Richard

[Deborah]

Yes, as you would expect running your exact code works here.

So it sounds like this is the fix:
1) Set AutoSizeRows = false
OR
2) Set AutoSizeRows = True AND ensure that one of the columns is set to WrapText AND a MinHeight is defined.

When I said that we need to have AutosizeRows set to true because we use wrapped text columns, I did not mean to imply that EVERY one of our grids uses wrapped text columns. So this fix still does not really work for me. :-(

But you said that this is something that will be fixed in your next rev?

[Richard Slade]

Hi. Sorry to hear that this isn't a valid fix for your situation. I don't work for Telerik. I'm just another forum user like yourself but I am hopeful that this may be fixed in the service pack for you. Richard

[Deborah]

Wow Richard! I thought you were from Telerik, hence the reason I was giving you a bad time about not fixing this. :-)

With both you and Emanuel spending so much time helping me, I originally thought that he worked for Telerik as well. You are both very dedicated!

Do Telerik people support the forums as well? Is there a way to get a "bug report" to them?

And to resolve this issue, per my much earlier message (Nov 26) I was able to get this to work in my code (my *real* application) using the work around that Emanuel defined on Nov. 25.

So I just wanted two things:
1) To provide Telerik with a reproducable case.
2) To request that Telerik fix this!

Now the question is, do I close this thread? If I do, will Telerik personnel not see it?

[Emanuel Varga]

Hello Deborah, Richard,

The best way to ensure they see it is to open a support ticket, if you cannot open one right now i can open one regarding this issue and communicate the result.

There is a very high probability that hey have seen this thread, but in a lot cases here, we are just providing some workarounds and there have more than a few cases where even if the thread was closed, they still acknowledged the bug

And like we already know, nothing is perfect and we're just trying to give a helping hand here and sharpen our skill set while we are at it.

Please let me know if you want me to open a support ticket with this issue or if you will open it yourself.

And again, sorry for just following this discussion from the shadows but I've been extremely busy lately :(

Best Regards,
Emanuel Varga

Telerik WinForms MVP

[Richard Slade]

Hi Deborah,

I'm always happy to try and help. As far as I know, Telerik always review all forum posts, even ones that have been marked as answer, though they have a lower priority than support tickets. You can open a support ticket by going to Support Tickets in Your Account.

I'd advise quoting this forum thread as a link so they don't get slowed down by reviewing two different modes of support request that lead to the same issue. Emanuel has kindly offered to open the ticket for you if you can't and if I can be of any further help, just let me know.

regards,
Richard

[Stefan]

Hello guys, 

I am getting straight to your questions Deborah. 

1. Usually, forum threads are reviewed by Telerik Support staff in usually 72 hours.
2. If you need a quicker answer or if you want to report a bug, feature, etc. you should use our Support System just like Richard has suggested. Support tickets are reviewed depending on the support package.

Additionally, in the support ticket you can attach projects that demonstrate the experienced issue(s) (Note: this will significantly decrease the time for solving the enquiry).

Now, as far as I understand, there are a few issues that you are experiencing. I will try to summarize them and please correct me if I am missing something:
1. When AutoSizeRows is enabled and you have GridViewComboBox column, the row is collapsed (not visible) due to the fact that it does not contain values. Once you select a value, the row size is not changed.
2. Again, with AutoSizeRows enabled in the same scenario when you select something from the ComboBox, the row is displayed incorrectly (as in this image). For this reason, you are setting the MinSize of a row in ViewCellFormattingEvent, which is the right approach until the issue is addressed.
3. When this visual glitch appears (from the previous paragraph) and you click on an item in the ComboBox, the drop down does not close. 

I have tested these scenarios and I can confirm that those are issues in RadGridView. I have added them in out PITS and we will address them in a future release. Here are the links to the PITS items: issue 1, issue 2, issue 3.

Deborah and Richard, your Telerik Points were updated accordingly.

@Emanuel and Richard - Thank you guys for the community effort.
 
Sincerely yours,
Stefan
the Telerik team

[Deborah]

Thanks. I look forward to seeing the fix.

[Nathaniel]

Was this ever fixed? I am running into this with Q1 2011 SP1, and so far I an unable to isolate the issue in a sample project. The workaround listed here doesn't work because the dropdown has a scrollbar and as soon as you click the scrollbar the dropdown closes. We are upgrading from 2010 Q1 SP2 and the problem didn't exist then.

UPDATE: In our case I have determined that it is something with our theme XML file, but I haven't figured out what.

[Stefan]

Hi Nathaniel,

Thank you for writing.

All issues from my previous post were resolved, as the PITS items are stating. However, you are mentioning that you have managed to determine that the reason for the issue comes from your XML file. Feel free to open e new support ticket with your project attached and a detailed description of the observed and the desired behavior. We will investigate the issue and we will try to find a proper solution.

Should you have any other questions, do not hesitate to ask.
 
Greetings,
Stefan
the Telerik team