I've been looking at the licensed source distribution (2017.1.118, retrieved with bower), and had a couple questions/comments.
- It looks like (aside from jquery) the third-party .js files that come with the minified release package aren't included? This would be "angular", "jszip" and "pako_deflate". It would seem that if working with source, one would have to check in the release package to see what was included there? Might there be a case to include these somewhere in the source package, or perhaps a reference to the versions included with the release package?
- The "kendo-ui/bower.json" file has the entry "version": "2016.3.1202" (not a public release?), although the js folder has the expected source code for "v2017.1.118". Did this file just get missed for updating? I don't think it causes a problem, although the "jquery" dependency has ">=1.9.1 <=2.1.1" and you may have intended this to be "<= 2.1.4" for the current 2.1.x release?
- Don't forget to update your Javascript Prerequisites doc page to include table entries for 2017.1.118! Also, Angular 1.6 was recently released; are there any notes on using it with Kendo? BTW, one of your other Angular articles seems to suggest that the Bad Things that the Prerequisites page warns about with "ng-model" and 1.5 actually started with 1.4.9? Perhaps the Prerequisites warning should be updated? I notice the release packages bundles Angular 1.4.6; was there a reason to not include 1.4.7 or 1.4.8?
- The release package has jQuery 1.12.3 - any reason this wasn't 1.12.4 (May 2016)? The included "pako_deflate.js" is 1.0.1 - upstream is 1.0.4 and I notice that 1.0.2 "Fixed nasty bug in deflate ... which could cause broken data in some rare cases."
3 Answers, 1 is accepted
Thanks for taking the time to report these problems and my apologies for the delayed response.
1) The third-party files are included in the bower package.
2) The bower.json file should point to the latest version:
"name": "kendo-ui",
"version": "2017.1.118+Official",
"dependencies": {
"jquery": ">=1.9.1 <=3"
}
Try clearing the Bower cache - "bower cache clean". Sounds like you might have a corrupted/outdated version of the package.
3) Will update the supported versions, thanks. I'll get a statement from the responsible developers regarding our Angular 1.5+ support.
4) We try not to update the bundled dependencies too often. This usually happens at the start of the release cycle to guard against regressions. That said, we're at this exact moment right now and can update the dependencies where possible.
I've updated our Telerik points as a token of gratitude for your involvement.
Regards,
T. Tsonev
Telerik by Progress
Rank 1
This is the first time I've done this (I've just started playing around with bower and gulp), so this is all from January 22 and later. The bower.json had "version": "2016.3.1202", which isn't listed as an actual release. I cleaned the bower cache and tried again tonight - I've put some of the relevant logging below. I also tried it with an explicit version number on the install url ("
bower install https://bower.telerik.com/bower-kendo-ui.git#~2017.1.118", and "...#2017.1.118"), and in all cases what I receive has a bower.json file with that "version": "2016.3.1202" line. You can see the bower logging grumble about the version mismatch between the declared "2016.3.1202" in the file it receives, and what the package resolves to "2017.1.118+Official". It really does seem like the package on "bower.telerik.com" has an incorrect "bower.json" file.
I also tried "bower install https://bower.telerik.com/bower-kendo-ui.git#~2016.3.1118". That seems to contain the same bogus "2016.3.1202" bower.json. Also, bower resolves that "~2016.3.1118" to "2016.3.1317". "13" isn't a month, or does that indicate some sort of rollover and an unlisted 2016R3SP2 repackage created for Jan 17/2017? Specifying "2016.3.1118" (without the tilde for accepting patch releases) resolves to "20162016.3.1118+SP2" as expected and has a legit "version": "2016.3.1118+SP2" in its bower.json.
Hope this helps.
$ bower cache clean
bower deleted Cached package jquery: /Users/myaccount/.cache/bower/packages/35300e45e44dbc6f186ed069533ef0af/1.12.4
bower deleted Cached package jquery: /Users/myaccount/.cache/bower/packages/35300e45e44dbc6f186ed069533ef0af/2.1.1
bower deleted Cached package kendo-ui: /Users/myaccount/.cache/bower/packages/3129c3760d9a84265a887b793515a455/2017.1.118%2BOfficial
$ bower install https://bower.telerik.com/bower-kendo-ui.git
bower bower-kendo-ui#* not-cached https://bower.telerik.com/bower-kendo-ui.git#*
bower bower-kendo-ui#* resolve https://bower.telerik.com/bower-kendo-ui.git#*
bower bower-kendo-ui#* checkout 2017.1.118+Official
...
bower bower-kendo-ui#* invalid-meta for:/var/folders/92/qjtwwkbj335cdrh8_l1xyz8w0000gn/T/myaccount/bower/d86d0a71b49c762e899774fef446d55f-64288-hSw2o1/bower.json
bower bower-kendo-ui#* invalid-meta The "main" field cannot contain minified files
bower kendo-ui#* mismatch Version declared in the json (2016.3.1202) is different than the resolved one (2017.1.118+Official)
bower kendo-ui#* resolved https://bower.telerik.com/bower-kendo-ui.git#2017.1.118+Official
bower jquery#>=1.9.1 <=2.1.1 not-cached https://github.com/jquery/jquery-dist.git#>=1.9.1 <=2.1.1
bower jquery#>=1.9.1 <=2.1.1 resolve https://github.com/jquery/jquery-dist.git#>=1.9.1 <=2.1.1
bower jquery#>=1.9.1 <=2.1.1 download https://github.com/jquery/jquery-dist/archive/2.1.1.tar.gz
bower jquery#>=1.9.1 <=2.1.1 extract archive.tar.gz
bower jquery#>=1.9.1 <=2.1.1 resolved https://github.com/jquery/jquery-dist.git#2.1.1
bower kendo-ui#^2017.1.118+Official install kendo-ui#2017.1.118+Official
bower jquery#>=1.9.1 <=2.1.1 install jquery#2.1.1
I can confirm that you're right. This is an actual issue that was caused by a stale cache on our distribution server.
Cleaning your cache now and installing should get you a correct bower.json with proper version and jQuery dependency.
Apologies for the caused inconvenience.
Regards,
T. Tsonev
Telerik by Progress