This is a migrated thread and some comments may be shown as answers.

[Solved] ScriptRegistrar order while using AssetHandler

9 Answers 127 Views

General Discussions

This is a migrated thread and some comments may be shown as answers.

This question is locked. New answers and comments are not allowed.

Kelly Stuard asked on 04 Feb 2010, 08:58 PM

Given the following:

    
            .Add("file1.js")  
        
            .Add("file2.js")  
        
            .Add("directory/otherfile.js")  
        
            .Add("file3.js")

The script render out in that order when the page is loaded normally. This is expected.

If i add '.Combined(true)' then suddenly they are rendered as one reference (expected). However, the single file that is output is in the wrong order. Any files without a subdirectory are rendered first, before the ones in a directory. This is killing me for script-dependency reasons.

Actual order when combined (unexpected):

    
            file1.js  
        
            file2.js  
        
            file3.js  
        
            directory/otherfile.js

9 Answers, 1 is accepted

answered on 08 Feb 2010, 12:01 AM

A little clarification, I guess. This actually presents a substantial problem, due to the way we use .js files (and I suppose .css files behave the same way).

Our adds go as follows:

    
            .Add("library/jquery.js")  
        
            .Add("library/ajax.js")  
        
            .Add("library/other-3rd-party.js")  
        
            .Add("our-stuff.js")  
        
            .Add("our-pagelevel.js")

Without .Combined() the scripts go out in the correct order (the order they were added). For whatever reason (I haven't been able to look through the asset handler to figure it out), it's rendering out in a different order (with the ones in the library directory last). As you can imagine, having the library scripts not loaded when our scripts do their thing causes massive JavaScript errors.

I'm just asking for consistancy between the methods of outputting scripts. It's very painful to have different behavior between development and release. Makes it harder to track down bugs.

Accepted

answered on 11 Feb 2010, 08:10 AM

Hello Kelly Stuard,

In WebAssetRegistry.cs replace this code:

foreach (MergedAssetDirectory directoy in asset.Directories)

{

foreach (MergedAssetFile file in directoy.Files.OrderBy(f => f.Order))

{

string path = "~/" + directoy.Path + "/" + file.Name;

string virtualPath = assetLocator.Locate(path, asset.Version);

string fileContent = virtualPathProvider.ReadAllText(virtualPath);

if (string.Compare(asset.ContentType, "text/css", StringComparison.OrdinalIgnoreCase) == 0)

{

string baseDiretory = virtualPathProvider.GetDirectory(virtualPath);

fileContent = ReplaceImagePath(baseDiretory, asset.Version, fileContent);

}

contentBuilder.AppendLine(fileContent);

physicalPaths.Add(pathResolver.Resolve(virtualPath));

}

with this code:

var files = asset.Directories

.SelectMany(d => d.Files.Select(f => new { Directory = d, File = f }))

.OrderBy(f => f.File.Order);

foreach (var pair in files)

{

string path = "~/" + pair.Directory.Path + "/" + pair.File.Name;