This is a migrated thread and some comments may be shown as answers.

Tons of false errors

23 Answers 254 Views

Code Analysis

This is a migrated thread and some comments may be shown as answers.

This question is locked. New answers and comments are not allowed.

23 Answers, 1 is accepted

answered on 02 Jun 2010, 10:12 AM

Hi Daniel Billingsley,

Sorry to hear that. Which version are you using? Q1 or Q1 SP? We are fixing such false positives with high priority, so each new version gets better in that respect. We'll release the first test version of Q2 soon, which will have more issues fixed. It's possible that your issues are already fixed as well.

Of course you could also give us some info about the false positives you are seeing. So we could make sure they are fixed for Q2. Sometimes a very small issue (e.g. JC not beeing able to find a particular type) can cause a lot of errors to be shown. Thanks for your help.

Kind regards,
Dennis :: Dr. Code
the Telerik team

Do you want to have your say when we set our development plans? Do you want to know when a feature you care about is added or when a bug fixed? Explore the Telerik Public Issue Tracking system and vote to affect the priority of the items.

answered on 15 Jun 2010, 09:11 AM

Hello,

I also have a lot of false errors. Our project is quite large and used by clients round the world, there are no errors in VS but JC reports 502! Nearly all of them are this:

VisualBasic.Net: Unknown method 'DBVarCharName()' of 'blah'

The source line is:

strr_NEW_COLUMN_DATA_TYPE(0) = DB.DBVarCharName() & "(145)"

With the empty parenthesis underlined in red.

If I right click on DBVarCharName and choose 'Just Navigate' and 'Go to definition' it jumps right to it!

How can it be an unknown method if it can navigate to it? The method definition is:

Public Overloads ReadOnly Property DBVarCharName() As String

Regards,

Mark Leavesley

answered on 17 Jun 2010, 10:57 AM

Hi Mark,

I tried to reproduce the issue with the information you provided but failed. This is some of the code I tried:

Module Module1

Sub Main()

Dim foo As String

Dim obj As X

foo = obj.DBVarCharName() & "(145)"

End Sub

End Module

Class X

Inherits Y

Public Overrides ReadOnly Property DBVarCharName() As String

Get

Return Nothing

End Get

End Property

End Class

Public Class Y

Public Overridable ReadOnly Property DBVarCharName() As String

Get

Return Nothing

End Get

End Property

End Class

This code does not produce any false errors here but of course it is just a small experiment. In order to investigate the issue we need more information or (at best) a small testcase with which we can reproduce this problem.

As Dennis said before, we are very interested in fixing issue like that and adding code which previously produced such issues to our regression suite. So please help us figuring this out.

Best wishes,
Hans Kratz
the Telerik team

answered on 17 Jun 2010, 01:06 PM

telerikjc.jpg

In the course of creating the test solution and comparing it to our real code I worked out the problem, below the modified solution:

                    Module Module2         
              Sub Main()         
                Dim foo As String         
                Dim obj As X = Nothing         
                foo = obj.DBVarCharName() & "(145)"         
              End Sub         
            End Module         
                     
            Class X         
              Inherits Y         
            End Class         
                     
            Public Class Y         
              Public Overridable ReadOnly Property DBVarCharName() As String         
                Get         
                  Return Nothing         
                End Get         
              End Property         
                     
              Public Overridable ReadOnly Property DBVarCharName(ByVal bar As Integer) As String         
                Get         
                  Return Nothing         
                End Get         
              End Property         
            End Class         

Attached is the error it generates. Hope this helps.

Regards,

Mark Leavesley

answered on 17 Jun 2010, 02:55 PM

telerik-missing-next.jpg

Looking through the other errors JC has reported...it's quite illuminating:

                        For i = 1 To D709B_PLANNING_SALES_PERIOD_COMPARISON_COUNT()         
                  If i > 1 Then : strl_SQL = strl_SQL & "," : End If         
                  strl_SQL = strl_SQL & " str_selected" & i         
                Next         
                     

Produces " Missing 'Next' " (see attachment) , "There is no applicable member or variable '[Next]'", "Unexpected end of block" and "Unexpected end of statement", twice.

Whereas:

                          strl_SQL = strl_SQL & "                           ) AS drv_insert          
                     

Rightfully produces an error "Missing line break", though I would suggest it's a bit misleading as the line break is not missing, it's the closing quote. Alarmingly, not only does VS not produce an error, the code actually runs and works as intended.

I also have a number of errors about using comparison operators with strings, i.e:

If string1 > string2 then

Unconventional maybe, but not actually an error?

The flip side to the error I reported earlier is that I have several "Several methods are applicable to ...", but it's not true!

Regards,

Mark Leavesley

answered on 18 Jun 2010, 08:10 AM

Hello Mark,

thanks a lot for your thorough investigation of those issues. I was able to reproduce all of them here with the information you provided and added them as four distinct bug reports to our issue tracker so you will be notified automatically once they are taken care of. We are dedicated to fixing them for the Q2 release or for the Q2 Service Pack 1 at the latest.

Thanks again for those most excellent reports. Since many of the VB language features (e.g. the support for unterminated string literals) are undocumented we rely on publicly available sourcecode and user feedback like yours to improve our VB support. If you encounter any other problems like this please report.

I have awarded you Telerik points for your effort.

Greetings,
Hans Kratz
the Telerik team

answered on 18 Jun 2010, 08:49 AM

Hi Mark,

well, one would expect that the language specification describes what is accepted by the compiler and what is not. Of course there are always bugs in language specifications and in compilers.

The VB.net language specification for VB.net 9 can be found here:
http://www.microsoft.com/downloads/en/confirmation.aspx?familyId=39de1dd0-f775-40bf-a191-09f5a95ef500&displayLang=en

Section 2.4.4 talks about string literals. There is nothing in there which suggests that an unterminated string literal like this are allowed. Still as you said the VB.net compiler compiles it just fine. So it is an undocumented feature/bug in the VB.net compiler.

We will change JustCode to accept unterminated string literals (since the VB.net compiler accepts them too) but emit a warning for them (since it is ugly to have them and not backed by the VB spec).

Greetings,
Hans Kratz
the Telerik team

answered on 13 Oct 2010, 07:45 PM

Please don't take this the wrong way....

but there are some things that Telerik has done really well, and some that make me just scratch my head.

CodeRush and ReSharper are both such great products, I have to wonder about the wisdom of spending your resources playing "catch up" there vs. adding features in areas where you are leading the industry. The way you'll keep me as a customer isn't by making another code tool that works almost as good as the competition - it's by making the products I couldn't find at the competition when I ended up with Telerik even better than what they're writing to keep up with you.

answered on 24 Oct 2010, 06:36 PM

Hello Daniel,

I think we have quite a bit to offer with JustCode. It is true that we we have to catch up in quite a few areas but there are other areas where the competition has to catch up (e.g. JavaScript support, solution checking speed, ...).

Of course false errors are very annoying which is why fixing them is one of our top priorities. For example the issues Mark reported were all fixed AFAIK. In order to fix them however we need a way to reproduce the problem, e.g. code snippets when sufficient, information about the solution setup or ideally a test solution which exhibits the problem. It would be really great if you could help us make JustCode better.

Best wishes,
Hans Kratz
the Telerik team

answered on 13 Nov 2010, 12:44 PM

error.png

Hi Telerik,
I'm testing JC and see a few advantages over the competitors.
But, look to the attachment. There is a strange JustCode-Error in a third-party js-file (simile-ajax-bundle.js).
I'm curious what's the reason.
Thanks,
Andreas

answered on 23 Nov 2010, 08:19 PM

Since people seem to be using this thread to report false positives, I'll add one. I just started trying out JustCode today, and so far I like it. :) I found this problem in an Outlook 2007 Add-in project (using VSTO, which is what you get if you create a new project under Office > 2007).

The false positives are on Outlook., and anything derived from it.

I've got Microsoft.Office.Interop.Outlook imported as part of the project (which is done automatically in this type of project). I suspect the issue JustCode is having is around this user namespace import: Outlook = Microsoft.Office.Interop.Outlook

I've included some code that illustrates the problem, but you can make it appear by simply creating a new Outlook 2007 add-in and doing "dim asdf as Outlook.Mailitem= nothing"

Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As Microsoft.Office.Tools.Ribbon.RibbonControlEventArgs) Handles Button1.Click

Dim mail As Outlook.MailItem = Nothing

Dim inspector As Outlook.Inspector = CType(Context, Outlook.Inspector)

mail = TryCast(inspector.CurrentItem, Outlook.MailItem)

If mail Is Nothing Then

' didn't work

Throw New Exception("Outlook Mail Item could not be created.")

End If

End Sub

Product Bundles

DevCraft

Web

Mobile

Document Management

Desktop

Reporting & Mocking

Automated Testing

CMS

UI/UX Tools

Debugging

Free Tools

Tons of false errors

23 Answers, 1 is accepted