I use fiddler to remove my banned and get into a game, but today it is not working

I wants to use FiddlerCore in an open-source application. I have known that there is an open-source application named KanColleViewer used it before, but as far as I know it changed to other HTTP packet capture library after some time. So does that mean I must buy a commercial license to use FiddlerCore?

I am familiar with dos commands but powershell commands are new to me.

I have been tasked with writing a powershell command script that does two things:

1. Deletes the contents (all subfolders and the contents of the subfolders) under a particular folder
2. remove a shortcut from the desktop

if that can not be done with simple commands, maybe the steps need to be broken down:

1. gets a list of subdirectores under a directory
2. navigates to each of these directories and deltetes the contents
3. remove the subdirectories
4. then remove shortcuts from the desktop.

There seems to be a problem with Firefox version 36.0 onwards with the Fiddler HTTPS decryption option.  The instructions at http://www.telerik.com/blogs/configuring-firefox-for-fiddler used to work for adding the Fiddler root certificate so that Firefox will trust the certificates that Fiddler issues.  This is also the only way to trust Fiddler for HSTS (HTTP Strict Transport Security) sites because Firefox doesn't allow adding regular "exceptions" for those sites.

After updating Firefox, I found that the Fiddler root CA no longer works to connect to the HTTPS websites.  Firefox gives a "ssl_error_bad_cert_domain" error.  An example of what this looks like is:

www.google.com uses an invalid security certificate. The certificate is only valid for *.google.com (Error code: ssl_error_bad_cert_domain)

 

So this appears to be failing to match the wildcard domain (*.google.com) to the website (www.google.com) and rejecting the certificate as a result.

I tried downgrading back to different Firefox versions, and found that 35.0.1 is the last one that seems to work properly for the Fiddler HTTPS decryption, with 36.0 breaking this functionality.

I first reported this issue on Mozilla support: https://support.mozilla.org/en-US/questions/1090724

 

Is this a known bug / break in compatibility?  Has anyone reported this issue yet and is there a known workaround?

Hi,

Just received new update and constantly have this problem.

Any help is appreciated.

Thanks

---------------------------
Uncaught Exception in Session #
---------------------------
Fiddler has encountered an unexpected problem. If you believe this is a bug in Fiddler, please copy this message by hitting CTRL+C, and submit a bug report at http://www.telerik.com/forums/fiddler.

Could not load file or assembly 'Microsoft.Applications.Telemetry, Version=1.1.145.0, Culture=neutral, PublicKeyToken=ffe01d0f25e9b4f1' or one of its dependencies. The system cannot find the file specified.

Type: System.IO.FileNotFoundException
Source: TelemetrySpy
   at TelemetrySpy.TelemetrySpy.AutoTamperRequestBefore(Session oSession)

   at Fiddler.FiddlerExtensions.(Session ) in C:\JenkinsHome\jobs\FiddlerReleaseBuild\workspace\Fiddler2\Common\Application\Extensions.cs:line 798

   at Fiddler.Session.() in C:\JenkinsHome\jobs\FiddlerReleaseBuild\workspace\Fiddler2\Common\Core\Session.cs:line 5198

   at Fiddler.Session.‘() in C:\JenkinsHome\jobs\FiddlerReleaseBuild\workspace\Fiddler2\Common\Core\Session.cs:line 3394

   at Fiddler.Session.(Object ) in C:\JenkinsHome\jobs\FiddlerReleaseBuild\workspace\Fiddler2\Common\Core\Session.cs:line 3347


Fiddler v4.6.20172.31233 (x64 AMD64) [.NET 4.0.30319.42000 on Microsoft Windows NT 10.0.15063.0] 
---------------------------
OK   
---------------------------

Normally I would not be asking for help with Windows XP, but I am trying to use Fiddler to capture the web traffic between a couple old appliances that require using ActiveX controls that only work on really old versions of internet explorer.  I'm using Windows XP as a VM hosted by Oracle Virtual Box.
I've installed the .NET framework full profile version 4.0 and installed the 4.0.3 patch and all related patches from Microsoft Windows Update.
When I install Fiddler, it lets me install Fiddler version 4, so I know I've got the .NET prereq met.
When I launch Fiddler, I get an error from 'Microsoft Application Error Reporting' DW20.EXE and if I click details it reads:
AppName: fiddler.exe      AppVer: 4.6.20171.26113     AppStamp:593ed566
ModName: clr.dll      ModVer: 4.0.30319.2034      ModStamp:52ccfa2b
fDebug: 0       Offset: 00342980
There are two corresponding event's generated in the Event Log's application branch, which are:
Source: .NET Runtime
Event ID: 1023
Application: Fiddler.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an internal error in
the .NET Runtime at IP 79482568 (79140000)
with exit code 80131506.
----------------------------
Source: .NET Runtime 4.0 Error Reporting
Event ID: 1000
Type: Error
Faulting application fiddler.exe,
version 4.6.20171.26113,
stamp 593ed566,
faulting module clr.dll,
version 4.0.30319.1022,
stamp 52ccf666,
debug? 0,
fault address 0x00342568.

=================================================================================
I uninstalled Fiddler v4, selected to remove all registry settings, and then used 7Zip to unzip the installer, then installed Fiddler v2.
When I launch it, I get this error when I click on the details:
AppName: fiddler.exe      AppVer: 2.6.3.48898     AppStamp:5899a1e2
ModName: mscorwks.dll      ModVer: 2.0.50727.3655      ModStamp:5266e523
fDebug: 0       Offset: 002efe54
------------------------------------------------------------------
The event log has two events in the application log, which are:
Source: .NET Runtime 2.0 Error Reporting
EventID: 1000
Type: Error
Description: Faulting application fiddler.exe,
version 2.6.3.48898,
stamp 5899a1e2,
faulting module mscorwks.dll,
version 2.0.50727.3655,
stamp 5266e523,
debug? 0,
fault address 0x002efe54.
---------------------------------------
Source: .NET Runtime
EventID: 1023
Description: .NET Runtime version 2.0.50727.3655 - Fatal Execution Engine Error (7A0BD76A) (80131506)
=====================================================================================
These are the Fiddler registry entries:
Windows Registry Editor Version 5.00
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2]
"JSEditor"="C:\\Program Files\\Fiddler2\\ScriptEditor\\FSE2.exe"
"DetectedBrowser"="errorPID"
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\Dynamic]
"Attached"=dword:00000000
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\ImagesMenuExt]
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\ImagesMenuExt\PNG&Distill]
"Command"="C:\\Program Files\\Fiddler2\\Tools\\PngDistill.exe"
"Parameters"="\"{in}\" prompt"
"Types"="image/png image/x-icon image/vnd.microsoft.icon"
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\MenuExt]
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\MenuExt\&Sandbox]
"Command"="iexplore.exe"
"Parameters"="http://fiddler2.com/r/?FiddlerSandbox"
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\MenuExt\&View IE Cache]
"Command"="shell:cache"
[HKEY_CURRENT_USER\Software\Microsoft\Fiddler2\UI]
"frmViewer_WState"=dword:00000002

Is it odd that the "DetectedBrowser"="errorPID" in the registry?
IE launched after the install by the installer, but was blank.  I could see two IE process IDs spawned by the Fiddler install, but they did not self close when the installer was finished installing Fiddler.  I've got IE version 8 installed.  I completely uninstalled IE8, returning me to IE6, and tried again with the same issue.  I tried installing IE8 again, and also had the same issue.

=====================================================================================
Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\CDF]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\CDF\v4.0]
"WMIInstalled"=dword:00000001
"SMSvcHostPath"="C:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
"NetTcpPortSharingInstalled"=dword:00000001
"HttpNamespaceReservationInstalled"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v1.1.4322]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v1.1.4322\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v2.0.50727]
"Install"=dword:00000001
"Version"="2.2.30729"
"MSI"=dword:00000001
"Increment"="3053"
"SP"=dword:00000002
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v2.0.50727\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000002
"Version"="2.2.30729"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0]
"Install"=dword:00000001
"Increment"="01"
"Version"="3.2.30729"
"SP"=dword:00000002
"MSI"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\1033]
"Install"=dword:00000001
"SP"=dword:00000002
"MSI"=dword:00000001
"Version"="3.2.30729"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Servicing]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Servicing\Windows Workflow Foundation]
"Install"=dword:00000001
"SPName"="SP2"
"SP"=dword:00000002
"MSI"=dword:00000001
"SPIndex"=dword:00000000
"Hotfix"=""
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup]
"Version"="3.2.30729"
"InstallSuccess"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Communication Foundation]
"ReferenceInstallPath"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"Version"="3.0.4506.2152"
"InstallSuccess"=dword:00000001
"RuntimeInstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\Windows Communication Foundation\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Presentation Foundation]
@="Windows Presentation Foundation"
"InstallSuccess"=dword:00000001
"ProductVersion"="3.0.6920.1427"
"InstallRoot"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\WPF\\"
"Version"="3.0.6920.1427"
"WPFReferenceAssembliesPathx86"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"WPFNonReferenceAssembliesPathx86"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\WPF\\"
"WPFCommonAssembliesPathx86"="c:\\WINDOWS\\system32\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Workflow Foundation]
"ProductVersion"="3.0.0.0"
"InstallDir"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"FileVersion"="3.0.4203.2152"
@="Windows Workflow Foundation"
"MajorBuildNum"="4203"
"InstallSuccess"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.5]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
"Version"="3.5.30729.01"
"InstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.5\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.5\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
"Version"="3.5.30729.01"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Client]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"MSI"=dword:00000001
"Servicing"=dword:00000000
"InstallPath"="C:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Client\1033]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"Servicing"=dword:00000000
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"MSI"=dword:00000001
"Servicing"=dword:00000000
"InstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full\1033]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"Servicing"=dword:00000000
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4.0]
@="deprecated"

Under:
HKLM/SOFTWARE\Microsoft\NET Framework Setup\NDP I've got:

Windows Registry Editor Version 5.00
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\CDF]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\CDF\v4.0]
"WMIInstalled"=dword:00000001
"SMSvcHostPath"="C:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
"NetTcpPortSharingInstalled"=dword:00000001
"HttpNamespaceReservationInstalled"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v1.1.4322]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v1.1.4322\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v2.0.50727]
"Install"=dword:00000001
"Version"="2.2.30729"
"MSI"=dword:00000001
"Increment"="3053"
"SP"=dword:00000002
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v2.0.50727\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000002
"Version"="2.2.30729"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0]
"Install"=dword:00000001
"Increment"="01"
"Version"="3.2.30729"
"SP"=dword:00000002
"MSI"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\1033]
"Install"=dword:00000001
"SP"=dword:00000002
"MSI"=dword:00000001
"Version"="3.2.30729"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Servicing]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Servicing\Windows Workflow Foundation]
"Install"=dword:00000001
"SPName"="SP2"
"SP"=dword:00000002
"MSI"=dword:00000001
"SPIndex"=dword:00000000
"Hotfix"=""
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup]
"Version"="3.2.30729"
"InstallSuccess"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Communication Foundation]
"ReferenceInstallPath"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"Version"="3.0.4506.2152"
"InstallSuccess"=dword:00000001
"RuntimeInstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\Windows Communication Foundation\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Presentation Foundation]
@="Windows Presentation Foundation"
"InstallSuccess"=dword:00000001
"ProductVersion"="3.0.6920.1427"
"InstallRoot"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\WPF\\"
"Version"="3.0.6920.1427"
"WPFReferenceAssembliesPathx86"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"WPFNonReferenceAssembliesPathx86"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.0\\WPF\\"
"WPFCommonAssembliesPathx86"="c:\\WINDOWS\\system32\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.0\Setup\Windows Workflow Foundation]
"ProductVersion"="3.0.0.0"
"InstallDir"="c:\\Program Files\\Reference Assemblies\\Microsoft\\Framework\\v3.0\\"
"FileVersion"="3.0.4203.2152"
@="Windows Workflow Foundation"
"MajorBuildNum"="4203"
"InstallSuccess"=dword:00000001
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.5]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
"Version"="3.5.30729.01"
"InstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v3.5\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v3.5\1033]
"Install"=dword:00000001
"MSI"=dword:00000001
"SP"=dword:00000001
"Version"="3.5.30729.01"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4]
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Client]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"MSI"=dword:00000001
"Servicing"=dword:00000000
"InstallPath"="C:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Client\1033]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"Servicing"=dword:00000000
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"MSI"=dword:00000001
"Servicing"=dword:00000000
"InstallPath"="c:\\WINDOWS\\Microsoft.NET\\Framework\\v4.0.30319\\"
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full\1033]
"Version"="4.0.30319"
"TargetVersion"="4.0.0"
"Install"=dword:00000001
"Servicing"=dword:00000000
[HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\NET Framework Setup\NDP\v4.0]
@="deprecated"
=========================================================================
I followed the recommendations at:
https://stackoverflow.com/questions/14056667/faulting-module-name-clr-dll-error-message-when-you-run-a-microsoft-net-fram/20028205#20028205
I installed the NDP40-KB2640103-x86.exe and the newer NDP40-KB2889629-x86.exe hotfixes for the .NET 4 Framework, but that didn't seem to change anything.
I also tried adding '<gcConcurrent enabled="false"/>' to the 'Fiddler.exe.config' file, but the crashing continues even with garbage collection disabled:
  <runtime>
    <generatePublisherEvidence enabled="false"/>
    <gcConcurrent enabled="false"/>
  </runtime>

I killed the 'Microsoft Application Error Reporting' DW20.EXE, so I could capture it's DMP files.  I have two DMP files, one from when launching Fiddlerv4 and another from launching Fiddlerv2.

They are on my OneDrive and can be downloaded here:
https://1drv.ms/f/s!Au7APktuLWGumgk2WndQJzoVbMTM

The files are named:
Fiddlerv4CrashOnStartup.dmp
Fiddlerv2CrashOnStartup.dmp

Please let me know what further steps I can do to aid in resolving this issue.

Thank you,

-=Tyson Flint

It would be really great if you could export the request inspector to a cURL request where a user can repeat the request or send the cURL string to others for testing.  PostMan provides a code pull-down menu that allows the user to export the http request to a variety of formats like a c# (restSharp), cURL, Python, etc.  

I realize it may be too much to expect all of the exports that PostMan supports.  However, cURL is the one that I needed the most in all my years of using Fiddler.  Frequently we need to send the original or modified request in the inspector to a colleague to try. 

Hi,

 

I've got W2012R2 with WPF app. This WPF app makes wrong HTTP call to a WCF service. However, when I run Fiddler on this local machine, I see no packets from this app. Moreover, Fiddler doesn't show this WPF app in available processes for intercepting. How can I make Fiddler intercept all HTTP traffic from a WPF app?

Hi,

I am using fiddlercore to analyze network traffic. Now I want to store the session recorded in a HAR file and load it later from the HAR file itself.

I am able to save the session in a SAZ file and load the same session later from SAZ file.

So, is there a way to convert SAZ file to HAR file.

OR

Store all session as HAR file.

And, load the session recorded from HAR file.

Thanks in advance !!

Regards,

Kallol Ghose

Hi,

I am using FiddlerCore to perform the below functions in order

     - Running fiddler core and storing the sessions in a SAZ file

     - Uploading the SAZ file and load sessions

     - Using autoresponder to respond to a session from the loaded session(if it exists)

I am using the following code to auto-respond

foreach (Session loadedSession in loadSessions)
                {
                    if (loadedSession.fullUrl.Equals(oS.fullUrl))
                    {
                        Console.WriteLine("Session Available in Loaded Session");
                        oS.utilCreateResponseAndBypassServer();
                        oS.requestBodyBytes = loadedSession.responseBodyBytes;
                        oS.oResponse.headers = loadedSession.oResponse.headers;
                        break;
                    }
                }

Where loadSessions are loaded from SAZ file

But I am not getting receiving any response if i open the pages for which the session have been loaded.

What am I doing wrong and what should be the correct approach.

Thanks in advance !!!!