Date, DateTime, Time Editor Templates

[David]

The Editor Templates for Date, DateTime, and Time included with the Q1 2011 (2011.1.315) release include the following method call:

.HtmlAttributes(new { id = ViewData.TemplateInfo.GetFullHtmlFieldName(string.Empty) + "_wrapper"})

This renders an invalid ID (under our model scenario, the ID ends up containing periods instead of underscores, since it is driving off the name attribute.

A dev I work with changed the editor templates to look like the following:

<%@ Control Language="C#" Inherits="System.Web.Mvc.ViewUserControl<DateTime?>" %>
<%
 string projectedGeneratedId = ViewData.TemplateInfo.GetFullHtmlFieldName(string.Empty).Replace('.', '_');
%>

<%= Html.Telerik().DatePicker()
  .Name(ViewData.TemplateInfo.GetFullHtmlFieldName(string.Empty))
  .HtmlAttributes(new { id = String.Format("{0}_wrapper", projectedGeneratedId) })
  .Value(Model > DateTime.MinValue? Model : DateTime.Today)
%>

Does that make sense?

David

[Georgi Krustev]

Hello David ,

You are absolutely correct about this code snippet:

ViewData.TemplateInfo.GetFullHtmlFieldName(string.Empty) + "_wrapper"

GetFullHtmlFieldName method  will return full name which maybe will include points, which is not a valid value for the id attribute. The modification which you proposed will fixed this issue.

The only purpose to add id attribute with HtmlAttributes method was to style components in the online demos. In other words this id is not required in order to get working UI component. That is why the best solution is to avoid usage of HtmlAttributes method in the editor templates. In other words Editor Template for DateTime for instance will be this:

<%@ Control Language="C#" Inherits="System.Web.Mvc.ViewUserControl<DateTime?>" %>

<%= Html.Telerik().DateTimePickerFor(m => m) %>

This Editor template is much more clean and readable.

As a gratitude of your feedback I have updated your Telerik points.

Best wishes,
Georgi Krustev
the Telerik team