Upload saving initial file twice

[Web Services]

Whenever I run this script, if the file doesn't exist, it saves it twice. If that file name does exist, then it only saves it once. Any ideas why?

Protected Sub submit_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles submit.Click
        Dim targetFileName
        fileOutput.Text = ""

        Dim counter = 1
        Dim targetFolder As String = Server.MapPath(attachedFile.TargetFolder)

        'check the file upload
        If (attachedFile.UploadedFiles.Count > 0) Then

            For Each postedFile As UploadedFile In attachedFile.UploadedFiles
                If Not [Object].Equals(postedFile, Nothing) Then
                    targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                    While System.IO.File.Exists(targetFileName)
                        counter += 1
                        targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                    End While
                End If 'if not object
                postedFile.SaveAs(targetFileName)
            Next 'for each uploaded file

        Else

        End If 'if attachedFile.UploadedFiles.Count

End Sub

[Genady Sergeev]

Hi,

Remove the

postedFile.SaveAs(targetFileName)

line from your code. It causes the duplicate saving. When there is TargetFolder set on the upload, it will automatically save the files there unless there is file exists name space collision.


Regards,
Genady Sergeev
the Telerik team

[Web Services]

I updated my code, but now if the file exists, it doesn't save a copy with the increment on the end

'check the file upload
        If (attachedFile.UploadedFiles.Count > 0) Then

            For Each postedFile As UploadedFile In attachedFile.UploadedFiles
                If Not [Object].Equals(postedFile, Nothing) Then
                    targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                    While System.IO.File.Exists(targetFileName)
                        counter += 1
                        targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                    End While
                End If 'if not object
                'postedFile.SaveAs(targetFileName)
            Next 'for each uploaded file

        Else

        End If 'if attachedFile.UploadedFiles.Count

[Kevin]

You need to change your code to this:

'check the file upload
        If (attachedFile.UploadedFiles.Count > 0) Then

            For Each postedFile As UploadedFile In attachedFile.UploadedFiles
                If Not [Object].Equals(postedFile, Nothing) Then
                    targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                    If System.IO.File.Exists(targetFileName) Then
                        counter += 1
                        targetFileName = Path.Combine(targetFolder, postedFile.GetNameWithoutExtension() + counter.ToString() + postedFile.GetExtension())
                        postedFile.SaveAs(targetFileName)
                    End If
                End If 'if not object
                'postedFile.SaveAs(targetFileName)
            Next 'for each uploaded file

        Else

        End If 'if attachedFile.UploadedFiles.Count

You need to call the postedFile.SaveAs line where you check if the file exists. I removed the While loop since it makes more sense to use an If statement to check if a file exists.

I hope that helps.