This is a migrated thread and some comments may be shown as answers.

Big issues for me

6 Answers 100 Views
Notification
This is a migrated thread and some comments may be shown as answers.
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
sitefinitysteve asked on 04 Jul 2011, 07:49 PM
You're embedding the icons as <img> tags with css clipping right? :/

So here's my list of problems
  1. Nowhere in the markup do you define the CSS class itself of the icon type, so I am totally unable to style\sprite this myself
    <span class="rnTitleBarIcon"><img alt="" src="/aspnet-ajax-beta/WebResource.axd?d=ggAcMRKG-k0cBWcn06l1bQ0-EcIDhDWZb12Lq-SE6ng5d2az3I1O-XNTxq83E4Fw_GW3CVlrOrhvkwJP1A2axcD5RKUIsMrmmQnYKcnjKzr3eF5qacTEvdl_o48AR9i_Z0Ff_wWqxIpI4gdVXoLrV2ESf8Ui7_izFZdbfQ0qtns1&t=634450297140000000"></span>
  2. In my custom skin I would much rather not have <img> tags, but instead background image positioning on the container if possible...

For release can you please
  1. Mark the icon types in the iconcontainer elements so I can style accordingly...or at all.  So like "rnTitleBarIcon delete", "rnTitleBarIcon info"
  2. Give me a property to just not render the img tags. One of the other RadControls (RadToolbar?) has a property to enable image sprites or something like that...enablebuttonsprites? Maybe replace it with an empty div or something I can play with without the obnoxious webresource.axd markup...not your fault on that :).

The baked in icons are nice, but are way outside our theme\style guidelines and they shouldn't be forced on us...just lacks the telerik polish.  Although I will greatly compliment whoever made the call to make it DIV based over tablebased (like the RadWindow)...thank you SO MUCH for that foresight.

Steve

6 Answers, 1 is accepted

Sort by
0
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
answered on 04 Jul 2011, 07:53 PM
**EDIT**

This one is SUPER minor (as I couldnt give a rats ass about IE6), but just a heads up on Stack Overflows in IE6 on the demo page when changing to center positioning.


http://demos.telerik.com/aspnet-ajax-beta/notification/examples/configurator/defaultcs.aspx
0
Bozhidar
Telerik team
answered on 05 Jul 2011, 08:42 AM
Hi Steve,

Thank you for contacting us and giving some feedback and good suggestions.
For that controls we have decided to use img tags and clip region because of accessibility reasons. If a user personalize the visual of its Windows with a high contrast theme, the browser will not display background images applied through CSS file. As we had some client issues with that problem, we have decided to use img tags and clip region for that controls. The same was done for RadRibbonbar control.

We will send your feedback to the developer and will consider if we could implement it. We will not be able to do that for the official release as our plans for the Q2 release are already set. We will do our best to include it for the Service Pack, but it will depend on how much scenarios should be tested and covered including new properties and / or functionality.

I have included a simple code showing a possible solution, but it is just a fast workaround and any possible improvements will look much better:

<%@ Register TagPrefix="telerik" Namespace="Telerik.Web.UI" Assembly="Telerik.Web.UI" %>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<head runat="server">
    <title></title>
    <style type="text/css">
        .rnOkTitleBarIcon
        {
            background-repeat: no-repeat;
        }
         
        div.rnOkContentIcon
        {
            background-repeat: no-repeat;
            width: 32px;
            height: 32px;
            clip: auto;
            top: 13px;
        }
         
        .rnOkTitleBarIcon img, .rnOkContentIcon img
        {
            display: none;
        }
    </style>
</head>
<body style="background: #fff; direction: ltr;">
    <form id="form1" runat="server">
    <asp:ScriptManager ID="ScriptManager1" runat="server">
    </asp:ScriptManager>
 
    <script type="text/javascript">
        function OnClientShowing(sender, args) {
            var contentIconEl = $telerik.getElementByClassName(sender.get_contentElement(), "rnContentIconClip", "div");
            Sys.UI.DomElement.addCssClass(contentIconEl, "rnOkContentIcon");
            var titleIconEl = $telerik.getElementByClassName($get(sender.get_id() + "_titlebar"), "rnTitleBarIcon", "span");
            Sys.UI.DomElement.addCssClass(titleIconEl, "rnOkTitleBarIcon");
        }
    </script>
 
    <telerik:RadStyleSheetManager ID="rsm1" runat="server">
    </telerik:RadStyleSheetManager>
    <br />
    <br />
    <telerik:RadNotification ID="RadNotification1" runat="server" Title="Title" EnableShadow="true"
        OnClientShowing="OnClientShowing" EnableRoundedCorners="true" VisibleTitlebar="true"
        ShowTitleMenu="false" Width="400" OffsetX="-60" OffsetY="-230" ShowInterval="500"
        Text="MorbisedturpisattortormalesuadcondimentumidlaoreetfelisMorbisedturpisattortormalesuadcondimentumidlaoreetfelis."
        TitleIcon="ok" Animation="Fade" ContentIcon="ok" Skin="Office2010Black">
    </telerik:RadNotification>
    </form>
</body>
</html>

For the time being you could use the TitleIcon=""  ContentIcon="" properties to put some icons that will fit your themes.

All the best,
Bojo
the Telerik team

Browse the vast support resources we have to jump start your development with RadControls for ASP.NET AJAX. See how to integrate our AJAX controls seamlessly in SharePoint 2007/2010 visiting our common SharePoint portal.

0
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
answered on 05 Jul 2011, 02:25 PM
Ok, fair enough on the img tags...I think I can work around it

I don't get why it's not possible to add the type CssClasses before release though?...

1) It wouldn't break any functionality...even for the testers
2) It's not like the code gold is off at the printers pressing CDs :)
3) Should be quick to implement, there's gotta be some sort of switch in there already deciding which image resource to include...Gotta be what like 2 weeks till release?

I sadly can't implement that workaround...it has to be able to live in a .Skin file as I don't want to have to keep re-implementing it on every notification use.
0
Bozhidar
Telerik team
answered on 06 Jul 2011, 10:46 AM
Hi Steve,

Generally speaking, every new feature goes through a strict process that include initial implementation, testing and documentation. As I previously noted, our ToDo list till the official release is already set and if we simply add this (without going through all the steps) there is a possibillity to introduce a bug for the first official version of the control, which is something we definitely don't want.

The official release is scheduled for the next week and we are finishing all testing and development in the end of this week, so we do not have enough time to add this feature as the Developer of that control is busy with other tasks.

I could not guarantee it, but that feature could be implemented before the official Service pack 1 release. in that case it will be available in the internal weekly builds. I will let you know when it is done.

Regards,
Bojo
the Telerik team

Register for the Q2 2011 What's New Webinar Week. Mark your calendar for the week starting July 18th and book your seat for a walk through of all the exciting stuff we will ship with the new release!

0
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
answered on 06 Jul 2011, 01:49 PM
Ahh, so I assume the top part was a cut\paste from a dev email? (diff font)

Ok fair enough, could I at least get a trackable PITS entry for it?
0
Georgi Tunev
Telerik team
answered on 07 Jul 2011, 10:36 AM
Hi Steve,

Here is the PITS Url:
http://www.telerik.com/support/pits.aspx#/public/aspnet-ajax/6786



Kind regards,
Georgi Tunev
the Telerik team

Register for the Q2 2011 What's New Webinar Week. Mark your calendar for the week starting July 18th and book your seat for a walk through of all the exciting stuff we will ship with the new release!

Tags
Notification
Asked by
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
Answers by
sitefinitysteve
Top achievements
Rank 2
Iron
Veteran
Bozhidar
Telerik team
Georgi Tunev
Telerik team
Share this question
or