NameValueCollection incorrectly decompiled

4 posts, 0 answers
  1. Paul
    Paul avatar
    1 posts
    Member since:
    May 2011

    Posted 26 May 2011 Link to this post

    Here is a bad decompile, NameValueCollection did not decompile corrrectly:
    See the three "preview.Item" assignments below.

    JustDecompile

     

    public static void Preview(Item item)
    {
        Assert.ArgumentNotNull(item, "item");
        if (item.Visualization.Layout == null)
        {
            SheerResponse.Alert("The start item cannot be previewed because it has no layout for the current device.
      
    Preview cannot be started.", new string[0]);
            return;
        }
        UrlString preview = Items.GetPreview();
        preview.Item = "sc_itemid";
        preview.Item = "sc_mode";
        preview.Item = "sc_lang";
        SheerResponse.Eval(string.Concat("window.open('", preview, "', '_blank')"));
    }

    Reflector:

    public static void Preview(Item item)
    {
        Assert.ArgumentNotNull(item, "item");
        if (item.Visualization.Layout == null)
        {
            SheerResponse.Alert("The start item cannot be previewed because it has no layout for the current device.\n\nPreview cannot be started.", new string[0]);
        }
        else
        {
            UrlString preview = GetPreview();
            preview["sc_itemid"] = item.ID.ToString();
            preview["sc_mode"] = "preview";
            preview["sc_lang"] = item.Language.ToString();
            SheerResponse.Eval("window.open('" + preview + "', '_blank')");
        }
    }
      
      
    Thanks!
    Paul
  2. Chris
    Admin
    Chris avatar
    221 posts

    Posted 27 May 2011 Link to this post

    Hello Paul,
    Thanks a lot for reporting this problem. We've logged this for fixing and hopefully the fix will be available for the official release in July.
    Btw, is there any chance that we can get this assembly? You can send it to us via the ticketing system or as general feedback ( http://www.telerik.com/account/support-tickets/general-feedback.aspx ).
    Thanks!

    Kind regards,
    Chris
    the Telerik team

    Explore the entire Telerik portfolio by downloading the Ultimate Collection trial package. Get now >>

  3. DevCraft banner
  4. John
    John avatar
    1 posts
    Member since:
    Jul 2011

    Posted 05 Aug 2011 Link to this post

    This problem still exists in 2011.1.728.1.  Problem is pervasive when decompiling references to Session and control Attributes collection for ASP.NET controls.
  5. Yordan Dikov
    Admin
    Yordan Dikov avatar
    69 posts

    Posted 10 Aug 2011 Link to this post

    Hi John,

    Thank you for reminding us about this issue. We are aware that the problem is still there. It still stays pending at our side, we just weren't able to fix it for July's release. I'm sorry for any inconvenience we might have caused.

    Looking forward to receiving from you more feedback.

    Best wishes,
    Yordan Dikov
    the Telerik team

    Explore the entire Telerik portfolio by downloading the Ultimate Collection trial package. Get now >>

Back to Top